网格灯箱图片显示顺序错误

zogstrip · 2026 年5 月 13 日 09:16

感谢 @Shauny 的报告。这次调试和修复的过程很有趣

github.com/discourse/discourse

FIX: Preserve original image order in grid lightbox (#39968)

main ← fix-grid-lightbox-order

opened 09:15AM - 13 May 26 UTC

ZogStriP

+174 -3

Inside a `[grid]` block, the lightbox arrow navigation followed column-balanced …DOM order instead of the original markdown order. For four images this resulted in 1, 3, 2, 4 because `Columns` distributes items by height into the shortest column. `lightbox.js` collects items via `querySelectorAll(".lightbox")`, which returns nodes in document order — the same scrambled order the layout algorithm produced. `Columns` now tags each item with `data-lightbox-position` carrying its original index before reordering. A new `sortLightboxItems` helper in `lightbox.js` reorders items within each grid by that attribute before they reach PhotoSwipe. The existing RTL reverse continues to apply on top, so right-to-left navigation now mirrors logical order rather than the scrambled layout. https://meta.discourse.org/t/402817

cc @davidb

话题		回复	浏览量
Introducing image grids in posts Announcements new-feature	42	7795	2026 年1 月 10 日
Image lightboxing does not respect manual resizing or [grid] tags Bug lightbox	4	352	2024 年11 月 30 日
Uploading images in order of filename Feature	30	1538	2018 年10 月 8 日
Lightboxed images do not have `vertical-align` set, misaligning them with naked `img`s Bug lightbox , fixed	2	282	2024 年6 月 18 日
Image lightbox not working after collapsed Bug chat	4	658	2023 年3 月 17 日

网格灯箱图片显示顺序错误

相关话题