# Help us test the rewritten Composer
**URL:** https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679
**Category:** Feature
**Tags:** feedback
**Created:** [10월 19, 2015, 4:51오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679 "2015-10-19T16:51:38Z")
**Posts on this page:** 20
**Page:** 2
### Author:  [@Erik\_Manger](https://meta.discourse.org/u/Erik_Manger)
#### Post date: [10월 21, 2015, 3:07오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/24 "2015-10-21T15:07:09Z")
Oh well I feel stupid… lol
I’m looking forward to extended functionality! The post editor has a lot of potential.
A feature a lot of people request from my site is the ability to upload files other than images…
But yeah, the emoticon popup is blurry… only thing I noticed.
---
### Author:  [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [10월 21, 2015, 3:09오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/25 "2015-10-21T15:09:19Z")
> [@eviltrout](#):
>
> We made the decision to rewrite our composer using Ember.js so it was more in line with the rest of our codebase and so that we could allow people to extend it more easily.
Can you elaborate on this? What changes might I be looking at for my plugins that add toolbar items?
---
### Author:  [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [10월 21, 2015, 3:10오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/26 "2015-10-21T15:10:45Z")
I haven’t 100% decided yet how the API will work. As always I’ll try my hardest (but it’s really hard!!) to retain backwards compatibility with APIs for adding buttons, but there will likely be a much shinier, simpler API for doing it.
One problem for example is the old one would show the quote button everywhere, not sure when composing a topic. Super confusing.
---
### Author:  [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [10월 21, 2015, 3:11오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/27 "2015-10-21T15:11:54Z")
Okay, backwards compatibility isn’t as critical for me (knowing how to add a toolbar item definitely is more important), except for the following:
Also, a follow up question.
If there are changes to how you add a toolbar item, how can we direct this against a specific version of Discourse so that our changes which will show as an update on older versions and obviously we don’t want them to upgrade the plugin as their Discourse version won’t support the new way of adding a toolbar item…
**Edit:**
Also I get this is complicated, just giving food for thought, because as a plugin developer, these are the things that concern me.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [10월 21, 2015, 9:54오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/28 "2015-10-21T21:54:23Z")
> [@Erik\_Manger](#):
>
> A feature a lot of people request from my site is the ability to upload files other than images
Just enable the file types you want to allow in site settings, this feature already exists. Out of the box we only allow image file types.
---
### Author:  [@Steven](https://meta.discourse.org/u/Steven)
#### Post date: [11월 6, 2015, 5:50오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/29 "2015-11-06T17:50:12Z")
[quote=“cpradio, post:27, topic:34679, full:true”]
Okay, backwards compatibility isn’t as critical for me (knowing how to add a toolbar item definitely is more important)[/quote]
A few days ago, @eviltrout added this commit :
[https://github.com/discourse/discourse/commit/5cd63088500f6dc76f39e060fd3a3ef3988a791e](https://github.com/discourse/discourse/commit/5cd63088500f6dc76f39e060fd3a3ef3988a791e)
It seems easier to add buttons but i’m not really competent enough to be sure 😅
---
### Author:  [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [11월 6, 2015, 5:55오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/30 "2015-11-06T17:55:09Z")
Agreed, but it doesn’t address the second, backwards compatibility, as soon as I use the new way, any stable implementations can’t upgrade to my plugin until the new composer is pushed to the stable branch.
---
### Author:  [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [11월 6, 2015, 7:31오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/31 "2015-11-06T19:31:24Z")
Which plugin is it? Maybe I can help you out.
---
### Author:  [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [11월 6, 2015, 7:32오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/32 "2015-11-06T19:32:43Z")
Well, I know others are using [GitHub - cpradio/discourse-plugin-composer-help-button: Add a Help Button to the Composer Window in Discourse · GitHub](https://github.com/cpradio/discourse-plugin-composer-help-button)
It is a very straight-forward plugin, so if there is a way to test if the new composer is available versus the old, so I can run the appropriate logic, that’d do it.
I can update the others I have once I know the best way to proceed. 😄
---
### Author:  [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [11월 6, 2015, 7:35오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/33 "2015-11-06T19:35:00Z")
You should be able to do it with something like:
```plaintext
if (typeof Discourse.ComposerEditorComponent === "undefined") {
// old composer
} else {
// new composer
}
```
---
### Author:  [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [11월 6, 2015, 7:36오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/34 "2015-11-06T19:36:01Z")
cool, I may try that later today. Is the new composer being used for actual posts yet? (or coming anytime soon)
---
### Author:  [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [11월 6, 2015, 7:45오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/35 "2015-11-06T19:45:37Z")
^^^ funny you should ask
I’ve just deployed the new composer that is using Ember.js instead of pagedown. It was a lot more work than I expected, because when I got in there to swap it out I realized how badly the state of our composer code was. We were abusing Ember in many ways to get that code to work and I made a huge effort to straighten it all out. It’s not perfect but it’s a huge improvement.
Please report any issues you see and I’ll fix them as fast as I can!
(first post made with new composer, woo)
---
### Author:  [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [11월 6, 2015, 7:47오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/36 "2015-11-06T19:47:50Z")
Awesome. Then I’ll definitely play around later tonight with it and probably tomorrow.
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [11월 6, 2015, 7:49오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/37 "2015-11-06T19:49:18Z")
This is a bug, the text box here used to be bigger and upload was at the bottom
Also need to test on win phone and android, getting size right was very fiddly
Old sizing
---
### Author:  [@tobiaseigen](https://meta.discourse.org/u/tobiaseigen)
#### Post date: [11월 6, 2015, 8:01오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/38 "2015-11-06T20:01:12Z")
Looks good on my Android 📱👌
---
### Author:  [@Steven](https://meta.discourse.org/u/Steven)
#### Post date: [11월 6, 2015, 8:23오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/39 "2015-11-06T20:23:08Z")
A tiny, tiny detail bugs me with the new composer
When I put the cursor in the middle of a text and use a button (or an emoji), it always goes at the end of the whole post.
First part : the cursor is between the lines
Second part : the generated code goes at the end.
I use Firefox 42.0
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [11월 6, 2015, 8:34오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/40 "2015-11-06T20:34:01Z")
What is with this underline here?
---
### Author:  [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [11월 6, 2015, 8:42오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/41 "2015-11-06T20:42:18Z")
The Hyperlink button doesn’t work. The dialog is hidden behind the editor.
This happens with latest Chrome on Windows 10.
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [11월 6, 2015, 8:53오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/42 "2015-11-06T20:53:27Z")
Can not click on x when a warning pops up.
---
### Author:  [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [11월 6, 2015, 8:53오후 UTC](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679/43 "2015-11-06T20:53:37Z")
Okay I’ve comitted a bunch of fixes which are still building and will be deployed shortly:
✅ Mobile viewport sizing
✅ Link modal appearing behind composer
✅ Hairline underneath buttons
✅ Inserting text between words was appearing at bottom
✅ Couldn’t dismiss validation messages
[이전 페이지](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679.md?page=1)
[다음 페이지](https://meta.discourse.org/t/help-us-test-the-rewritten-composer/34679.md?page=3)