Don
Novembro 13, 2024, 6:23am
1
Olá
Encontrei alguns lugares onde acho que a presença online também deveria ser oculta.
Presença no chat, quando você escreve uma mensagem, ela aparece na parte inferior, mesmo que você oculte sua presença.
Acho que no resumo da página do usuário, nas estatísticas, a seção “Visto pela última vez” também deveria ser ocultada para os usuários se a opção “Ocultar presença” estiver ativa.
Também seria bom se funcionasse como o ponto 2 com o componente de tema “Última vez visto” Cartão do Usuário .
Obrigado
4 curtidas
lindsey
Novembro 21, 2024, 3:35pm
2
Obrigado por compartilhar essas ideias! Vou mover isso para Feature
1 curtida
Don:
Presença no chat, quando você escreve uma mensagem, ela aparece na parte inferior, mesmo que você oculte sua presença.
Isso será corrigido por
main ← fix-is-replying-when-offline
opened 06:57PM - 03 Dec 24 UTC
While trying to reproduce an issue reported internally where a user saw the "is … replying..." from another user who had disabled presence (aka. was "offline"), I noticed something odd about the way we "notify" presence via `notifyState`. The way it is setup up, it's being called on every "input" event in the composer/editor, due to it tracking the "reply" property of the composer model. That's fine, but the way the `helperFn` helper works, make it so we're calling the `on.cleanup` callback also on **every** "input" events in the composer/editor. For every character we enter in the composer, we're "entering" the presence channel and immediatelly "leaving" it...
If I remove the checks on `reply` (and thus the auto-tracking), then the `notifyState` function is called much less frequently. But we have some specs that expects us not to "publish" our presence when we open the composer and the reply is "empty".
Note: I switched to using `replyDirty` instead to re-use the checks the composer model is already doing to ensure we actually have changed something in the reply.
The best I came up with was not to rely on the `helperFn` but now, there's no way (that I could find) to call `composerPresenceManager.leave()` when the composer is closed. I tried a lot of different ways, but none worked. I'm sure it's something stupid easy, but I can't figure it out just now.
Internal ref - t/127490/74
(assim que eu conseguir fazer funcionar corretamente
2 curtidas
chat
committed 11:21AM - 04 Dec 24 UTC
...since it was mostly duplicating the work the "ComposerPresenceManager" was do… ing.
So now the #chat composer uses the same "presence manager" as the composer, benefiting from the "hide presence" checks, with the only difference that the "keep alive" timeout is 5s for chat and 10s for topics/posts.
4 curtidas
)