Home page 404s if top_menu is garbage


(Kane York) #1

Found while monkey testing.

Seting this in the site settings…

leads to this when attempting to load the homepage:

Nothing shows up in /logs. /latest, /top, etc will still load.

Sounds like a good motivator for that site settings validation system…


Crashed my discourse while changing settings in admin section
(Jeff Atwood) #2

Do we validate this now that @neil did all the validation work on settings? A broken top_menu would be very bad.


Crashed my discourse while changing settings in admin section
(Kane York) #3

Nope - esp. seeing that any valid topic filter can be put there.

Maybe a custom validation could work?


(Robin Ward) #4

I confirmed that this is fixed in master. You can still add garbage items using the UX, but they are silently ignored by the front end code.


(Robin Ward) #5