How to read commits on Github?

(Christoph) #1

Continuing the discussion from Onebox shown as iframe raw html:

Could you explain what the :x: means next to a commit on Github if it doesn’t mean "tests not passed? Or, perhaps more importantly, how do I know if tests have passed or failed?

And, while we’re at it, another question about reading discourse on Github: when @techAPJ recently fixed an issue I had reported I wanted to upgrade as soon as this commit reached “'tests-passed”:

So I went to admin/upgrade and clicked on the discourse build number (or whatever it is called) to check the diff view showing all the commits that I would get if I upgraded. But I couldn’t see Arpit’s commit at all. Where or when would I have seen it?

(cpradio) #2

If you place your mouse over the X, it states “Failure: The Travis CI build failed”, which seems self-explanatory to me as to what it indicates, however, you must click on it to see why it failed.

You wouldn’t… as it was not in discourse, but a gem/plugin that discourse utilizes.

(Christoph) #3

Apart from that I have no clue what Travis is, I also thought it was self evident: something failed, i.e. something is not working which means it didn’t pass the tests which means it won’t be part of my update. But then I was told:

Hence my question…

Aah, that makes sense. So do I simply assume that such commits to a gem will be handed through to my discourse upgrade straight away?

(cpradio) #4

So click it? Clicking it usually gives a good indication or at least lets you start to try and digest why it failed, whether it was Travis being temperamental or an actual failure.

Once it is updated on onebox | | your community gem host, yes, the next upgrade will pull it in.