아이콘 유형 SiteSetting

개발
1

I am trying to add a SiteSetting to my plugin that can control the icons displayed for some components. The component itself was already going to be user customizable, so I wanted to add the SiteSetting as a way for staff to define the default icon. I know there is emoji_list type for SiteSettings, but there doesn’t seem to be one for SVG icons?

From what I can see, most plugins/TC use either image upload or plain string for icon settings. Am I missing a type/validator I can use? It feels weird to tell people to look up the styleguide and type the name of the icon.

2

I think it’s a case where we don’t have any icon based site settings, so we haven’t added a type for it. We have an icon picker component that’s made its way into other parts of the app, but nothing currently in site settings.

3

그건 타당합니다. 코어가 이를 필요로 하는 구체적인 시나리오는 솔직히 잘 떠오르지 않아요. 아마도 테마/TC나 플러그인처럼 UI에 초점을 맞춘 설정이 필요한 경우에만 유용할 것 같거든요.

저는 일반 사용자가 더 쉽게 접근할 수 있는 다른 곳에서 아이콘 선택기 컴포넌트를 사용하고 있습니다. 하지만 제가 염두에 두고 있는 특정 사용 사례는 기본 아이콘 설정 같은 기능에 해당합니다. SiteSetting 타입의 객체와 결합하면, 관리자가 특정 기능을 템플릿화하는 것이 더 쉬워질 것입니다.

코어에서 이를 사용하는 코어 사이트 설정이 없더라도, 코어의 SiteSettings에 icon_type 타입을 추가하는 것에 대해 팀이 개방적인 태도를 보일까요? 필요할 경우, 이 주제를 Contribute > Feature 요청으로 다시 여는 것도 괜찮습니다.

4

Any update on this? I noticed that reactions will be added to core, and that plugin currently has the Discourse reactions like icon setting where you need to enter the icon name manually.

5

No plans at the moment, but maybe that’s a good opportunity for it. I’ll pass the idea along.

6

yea it would be great to be able to use this in component settings, especially object type settings - can this be added please?

image
image297×427 12.1 KB

similar request also mentioned here:

7

There is now an icon type site setting.

https://github.com/discourse/discourse/pull/38779

8

This is great! I’m assuming it can be used for TCs as well? Time to start updating some with this!

9

I am not sure that’s the case. There is no icon type here

I think you cannot use the emoji setting type from site settings like Emoji deny list in themes either

10

i don’t think it is yet (at least i couldn’t get it to work).

are there any plans for supporting type: icon inside object schemas for theme components, like this?

    links:
        type: objects
        schema:
          name: menu_link
          identifier: text
          properties:
            icon:
              type: icon
              required: true
            text:
              type: string
              required: true
              validations:
                min_length: 1
                max_length: 100
            url:
              type: string
              required: true
              validations:
                min_length: 1
                max_length: 500
...