Icons in some discobot messages broken


(Christoph) #1

I just noticed that the path to some of the font-awesome icons seem to have changed so that some of the discobot message are broken. For example:

The text content element for the above is:

But I can now show you some cool features of this forum right now. :sunglasses: Are you ready? :rocket: Let's start by **bookmarking this private message:** just select <img src="/images/font-awesome-ellipsis.png" width="16" height="16"> below  and then hit <img src="/images/font-awesome-bookmark.png" width="16" height="16"> .

This part of the message is customized so I assume that the icons are only broken in customized messages. So basically this means that everyone who has customized any of the discobots messages needs to check if a font-awesome icon is in them and update its path. But the problem is that this will only fix any messages created from now on. All old discobot messages are broken. Wouldn’t it be possible to make the new paths compatible with the old ones? Symlinks, for example?

And then I found another broken text element (discourse_narrative_bot.new_user_narrative.search.instructions) which I had also customized slightly. But here reverting to the default text did not fix it. This is the default copy:

_psst_ … I’ve hidden a surprise in this topic. If you’re up for the challenge, **select the search icon** <img src="%{base_uri}/plugins/discourse-narrative-bot/images/font-awesome-search.png" width="16" height="16"> at the top right &#8599; to search for it.

Try searching for the term "capy&#8203;bara" in this topic

which produces this:

psst … I’ve hidden a surprise in this topic. If you’re up for the challenge, select the search icon at the top right :arrow_upper_right: to search for it.

Try searching for the term “capy​bara” in this topic

If I remove the %{base_uri} part of the path, it works:

I’m not sure if more things have been broken, but something most have gone wrong in a recent update.


(Jeff Atwood) #2

Aha @tgxworld we should fix this.


(Alan Tan) #4

When the plugin was merged into core, we added a job to remap the images. Can you try running Jobs::DiscourseNarrativeBot::RemapOldBotImages.new.execute_onceoff({}) again?

Are you running on a subfolder setup? The image is loading properly on meta https://meta.discourse.org/plugins/discourse-narrative-bot/images/font-awesome-search.png