# Iframe onebox has stopped working

**URL:** <https://meta.discourse.org/t/iframe-onebox-has-stopped-working/56091>\
**Category:** Product Support\
**Created:** [20. Januar 2017 um 18:58 UTC](https://meta.discourse.org/t/iframe-onebox-has-stopped-working/56091 "2017-01-20T18:58:57Z")\
**Posts on this page:** 1\
**Showing post:** 7

<div class="post-metadata">

**Author:** ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)\
**Post date:** [10. März 2017 um 15:22 UTC](https://meta.discourse.org/t/iframe-onebox-has-stopped-working/56091/7 "2017-03-10T15:22:48Z")

</div>

I’ve finally tracked down the cause of this. It broke on 6th Jan, after this commit by @zogstrip

> <https://github.com/discourse/onebox/commit/fa6ffc4e3b706567497a30908b72b26386562693>

My iframe already has a fixed height, defined in pixels like this

```plaintext
<iframe src="http://discourse-test.taylorhq.co.uk/embed.html" frameborder="0" width="100%" height="250"> </iframe>

```

The commit above added checks that `data[:height]` exists before accepting a ‘rich’ onebox… however, it’s not pulling that height from the parsed HTML, it’s trying to get it from the oembed JSON file. @zogstrip is this expected behaviour? Should I be defining the height of the iframe in the oembed JSON?

---

_[View the full topic](https://meta.discourse.org/t/iframe-onebox-has-stopped-working/56091)._