# Image button icon instead of upload icon

**URL:** https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841
**Category:** Bug
**Created:** [June 14, 2018, 4:20am UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841 "2018-06-14T04:20:12Z")
**Posts on this page:** 6
**Page:** 1

<div class="post-metadata">

### Author: ![davidkingham](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/davidkingham/32/119528_2.png) [@davidkingham](https://meta.discourse.org/u/davidkingham)
#### Post date: [June 14, 2018, 4:20am UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841/1 "2018-06-14T04:20:12Z")

</div>

> [@Should attaching an image be more obvious?](https://meta.discourse.org/t/should-attaching-an-image-be-more-obvious/31315/14):
>
> The easy way to get the picture icon is turn off the optional file types you have allowed for upload.

I have my file types for uploads set to defaults of just images but I still see the upload button rather than the image button, is there anywhere else besides this setting that would trigger this?

 ![image](https://global.discourse-cdn.com/meta/original/3X/3/5/35ddd7f921bdeab15145c9293bd93de4e8ce816c.png)

 ![image](https://global.discourse-cdn.com/meta/original/3X/7/e/7e01e85d325b185a4c630f56a5d17583fc39729b.png)

 ![image](https://global.discourse-cdn.com/meta/original/3X/f/d/fd64783eacac383611f2012b016545b213aca8d1.png)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [June 14, 2018, 4:40am UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841/2 "2018-06-14T04:40:06Z")

</div>

Did we regress here @jomaxro?

---

<div class="post-metadata">

### Author: ![jomaxro](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jomaxro/32/126216_2.png) [@jomaxro](https://meta.discourse.org/u/jomaxro)
#### Post date: [June 14, 2018, 5:54pm UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841/4 "2018-06-14T17:54:16Z")

</div>

Yeah, we do appear to have regressed here. The modal is still correct (text is the image-only strings, icon in button is picture) but the icon in the composer is wrong.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [June 14, 2018, 9:13pm UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841/6 "2018-06-14T21:13:34Z")

</div>

To clarify for @j.jaffeux, if the allowed filetypes are all default (.jpg, .gif, .png) then the glyph should be of an image, because those are the only types allowed. Once you add additional filetypes the glyph changes to generic upload.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [June 18, 2018, 9:17am UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841/7 "2018-06-18T09:17:36Z")

</div>

Good catch David! Thanks.

This should be fixed by:

[https://github.com/discourse/discourse/commit/4b604b1e68f51650ba78b1853b99a72f6e4c9894](https://github.com/discourse/discourse/commit/4b604b1e68f51650ba78b1853b99a72f6e4c9894)

I created a common implementation to decide which icon to display which should avoid any difference in the future.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [June 18, 2018, 9:17am UTC](https://meta.discourse.org/t/image-button-icon-instead-of-upload-icon/89841/8 "2018-06-18T09:17:42Z")

</div>