Images in the welcome email load over http, breaking ssl


(Allen - Watchman Monitoring) #1

So, as I edit the server.en.yml with each reload, I hope for the images to be loaded from our own repo instead of over http

http://www.discourse.org/images/welcome/notification-panel.png

That way our nice SSL lock won’t get uglied

Is this something the discourse team wants to address?


Add link to commit on GitHub when closing a fixed bug/added feature
Is the bug reporter badge automatic?
(Sam Saffron) #2

Yes, this is a bug we should be rendering protocol agnostic images there


(Michael Downey) #3

Wait, why:

  1. Is the content for this new user PM different than the one for my site?
  2. Are the images being loaded from www.discourse.org instead of the local Discourse server?

(Jeff Atwood) #4

We cannot render protocol agnostic images there as https is not available on www.discourse.org outside the buy page, and we certainly don’t want to send forced-https images to sites that are http themselves…


(Sam Saffron) #5

I guess that leaves us with just shipping these images with Discourse, seems more correct anyway as it would work better with insane intranets.


(Jeff Atwood) #6

Yeah this was a good thing you brought up @watchmanmonitor because all the PMs were having their remote images “downloaded by system”! :anguished: Seriously.

Anyway, now:

  • all the welcome PM images are now local to the site, in /images/welcome
  • they can be easier customized to taste
  • I scaled the images down a bit (dynamically, in html width/height dimensions) as I think I made them a tad too large originally
  • I updated the images with a few minor style changes we made since they were created (“new” icon, etc)

Also the old (slightly updated) images are still there on discourse.org forever just in case.

So… should be all better when you get latest!


(Jeff Atwood) #7

Add link to commit on GitHub when closing a fixed bug/added feature