带提醒的改进书签

martin · 2020 年4 月 28 日 06:47

今天收获颇丰。以下 PR 已合并，除最后一个外，其余均已上线 Meta：

github.com/discourse/discourse

FIX: improves bookmark shortcut reliability (#9547)

master ← jjaffeux:stop-shortcut-propagation

merged 12:33AM - 28 Apr 20 UTC

jjaffeux

+64 -26

This commit reworks slightly the `toggleBookmark` and `toggleBookmarkTopic` func…tions. The following cases have been identified: - Pressing [f] (toggleBookmarkTopic) - a topic list item is selected, we attempt to toggle the related topic - a post is selected, we bookmark the associated topic - nothing is selected, if there's a currentTopic we bookmark it - Pressing [b] (toggleBookmark) - a post is selected, we bookmark it - a topic list item is selected, we attempt to toggle the related topic - nothing is selected, if there's a currentTopic we bookmark it Note this, commit also reduces jquery usage, a bug where the [f] shortcut was propagated to the modal input, and attempts to fix a bug when bookmarking a topic list item on the front page and the firstPost couldn't be found, current repro before fix: - navigate to / - press [j] to select a topic list item - press [f] - `Uncaught TypeError: Cannot read property 'post_number' of undefined` error appears in console, the topic is not bookmarked

github.com/discourse/discourse

FIX: Topic user bookmarked column logic was not correct (#9563)

master ← issue/fix-topic-user-bookmarked-column-logic

merged 06:19AM - 28 Apr 20 UTC

martin-brennan

+52 -13

Make sure the topic_user.bookmarked column is set correctly when user bookmarks/…unbookmarks any post in a topic. For example, you bookmarked a post in the topic that was not the OP, the bookmark icon in the topic list would not be shown. Same if deleting a bookmark for the last bookmarked post in a topic, the bookmark icon in the topic list would not be removed. ![image](https://user-images.githubusercontent.com/920448/80441440-44073980-894e-11ea-8f18-bccd09de29e4.png) * Previously this was only setting it to true if bookmarking the OP/topic, which was not correct -- we want to show the icon on the topic list if any post is bookmarked. * Also set to false if unbookmarking the last bookmarked post in the topic. Also in this PR is a migration to correct any out of sync `topic_user.bookmarked` columns, based on the new logic.

此外，FIX: Do not save bookmark if close (X) on modal is clicked by martin-brennan · Pull Request #9541 · discourse/discourse · GitHub 预计很快也将合并。我还提交了一个 PR，旨在将 /bookmarks-with-reminders 的 URL 改回 /bookmarks，希望明天能合并该 PR：https://github.com/discourse/discourse/pull/9566。

“主题用户书签列逻辑不正确”的修复预计将在几小时内上线 Meta。本周晚些时候，我们将为所有这些修复推出另一个 Beta 版本。

话题		回复	浏览量
Bookmark labels to save for later Feature	36	9673	2018 年4 月 13 日
Disappearing bookmarks and expected behavior of /bookmarks Bug bookmarks	23	2183	2023 年11 月 7 日
Discourse Version 2.5 Announcements release-notes	3	14756	2020 年6 月 24 日
Allow all users to set topic reminders Feature	20	2363	2021 年7 月 7 日
Discourse 2.5.0.beta3 Release Notes Announcements release-notes	1	4698	2020 年4 月 22 日

带提醒的改进书签

相关话题