带提醒的改进书签

martin · 2020 年4 月 29 日 02:21

另一个更新——这两个 PR 现在都已合并，没有遗留的 bug。我现在正在处理最后一个 PR，将变量名等（如 bookmarkWithReminder）改回 bookmark。

github.com/discourse/discourse

FIX: Do not save bookmark if close (X) on modal is clicked (#9541)

master ← issue/cancel-bookmark-save-if-modal-close-clicked

merged 10:45PM - 28 Apr 20 UTC

martin-brennan

+17 -8

* After this change the bookmark will still be saved if clicking out of the moda…l or pressing escape * To achieve this I implemented an initiatedBy parameter for modal closing from d-modal. If clicking on the cross it is initiated by close, if clicking out of the modal it is by click out. * These options can then be compared in controllers consuming `onClose`

话题		回复	浏览量
Bookmark labels to save for later Feature	36	9599	2018 年4 月 13 日
Disappearing bookmarks and expected behavior of /bookmarks Bug bookmarks	23	2149	2023 年11 月 7 日
Discourse Version 2.5 Announcements release-notes	3	14732	2020 年6 月 24 日
Allow all users to set topic reminders Feature	20	2328	2021 年7 月 7 日
Discourse 2.5.0.beta3 Release Notes Announcements release-notes	1	4690	2020 年4 月 22 日

带提醒的改进书签

相关话题