martin
2020 年4 月 29 日 02:21
122
Another update – both of these PRs are now merged and there are no outstanding bugs. I am now just working on a final PR to rename variables etc. like bookmarkWithReminder back to bookmark.
master ← issue/cancel-bookmark-save-if-modal-close-clicked
merged 10:45PM - 28 Apr 20 UTC
* After this change the bookmark will still be saved if clicking out of the moda… l or pressing escape
* To achieve this I implemented an initiatedBy parameter for modal closing from d-modal. If clicking on the cross it is initiated by close, if clicking out of the modal it is by click out.
* These options can then be compared in controllers consuming `onClose`
master ← issue/change-bookmarks-with-reminders-route-back-to-bookmarks
merged 12:53AM - 29 Apr 20 UTC
* Bookmarks with reminders is a core feature now, no need to have a separate URL…
* Keep around the old /u/:username/activity/bookmarks-with-reminders route for backwards compat in Ember but just redirect to user activity bookmarks.
12 个赞