Inadvertent flood of emails / notifications when attempting to silently move Topics between categories

Good point. I’m honestly not sure.

I do see that’s exactly the use case described in the original feature request:

I also see that several folks thought the same thing when they saw the new checkbox: Bulk editing topic categories should not trigger thousands of email notifications - #12 by mbauman

The PR itself also makes it sound like that was the intention:

When the “Perform this action silently” checkbox has been checked, the :notify_category_change sidekiq job should not be enqueued.

But I’m not seeing explicit spec coverage for this case.

Admittedly, I’m a bit out of practice readying ruby specs since I haven’t write code day to day for the past few years, but this does feel like a possible gap.

Smells more like a bug to me now. Not sure if regression or not, but does feel like we’re missing coverage for this case.

3 Likes