# Inline PDF Previews
**URL:** https://meta.discourse.org/t/inline-pdf-previews/157649
**Category:** Theme component
**Tags:** official, desktop, pdf-previews
**Created:** [July 13, 2020, 9:18pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649 "2020-07-13T21:18:10Z")
**Posts on this page:** 20
**Page:** 3
### Author:  [@omarfilip](https://meta.discourse.org/u/omarfilip)
#### Post date: [October 20, 2021, 9:10pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/55 "2021-10-20T21:10:33Z")
Excellent! Thanks @Johani. I can confirm it works in all 3 browsers now.
---
### Author:  [@nathank](https://meta.discourse.org/u/nathank)
#### Post date: [October 22, 2021, 1:12am UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/56 "2021-10-22T01:12:27Z")
Fantastic - these are solid improvements and clearly a lot of work to achieve. Thanks for listening to us slightly annoying co-conspirators in the self-hosted world!
Does the Component now work with S3 uploads?
---
### Author:  [@Johani](https://meta.discourse.org/u/Johani)
#### Post date: [October 22, 2021, 12:17pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/57 "2021-10-22T12:17:14Z")
> [@nathank](#):
>
> Does the Component now work with S3 uploads?
I haven’t tried it, but It should work if your bucket is configured correctly. This component makes a [request](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest) to load the PDF
[discourse-pdf-previews/javascripts/discourse/initializers/initialize-for-pdf-preview.js at main · discourse/discourse-pdf-previews · GitHub](https://github.com/discourse/discourse-pdf-previews/blob/main/javascripts/discourse/initializers/initialize-for-pdf-preview.js#L78)
These types of requests made in JavaScript are blocked if the origin is not allowed access to the file. You then end up with a [CORS](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS) error. If you check the console, you’ll probably see something along the lines of this.
There’s not much the component can do about this. It all has to be handled in your S3 configuration. The origin - your Discourse domain - must be allowed to make such requests to avoid CORS issues.
---
### Author:  [@nathank](https://meta.discourse.org/u/nathank)
#### Post date: [October 28, 2021, 9:52pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/58 "2021-10-28T21:52:16Z")
Thanks! I’ll bravely take the plunge back to S3 shortly.
### Another suggestion: tab when space before filename
What I want is for the pdf to be inline by default, and to open in a new tab if the space is put in the filename. This gives authors the choice per pdf of inline vs tab rather than per component.
Perhaps the component setting should instead be “What default behaviour do you want?” and if a space is put in you get the other.
Or alternatively you could ask what the space should do (inline / tab / download).
---
### Author:  [@omarfilip](https://meta.discourse.org/u/omarfilip)
#### Post date: [November 1, 2021, 7:07pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/59 "2021-11-01T19:07:41Z")
Aargh! Chrome is again showing only gray boxes. FF and Safari are OK.
---
### Author:  [@Alon1](https://meta.discourse.org/u/Alon1)
#### Post date: [November 2, 2021, 7:30pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/60 "2021-11-02T19:30:55Z")
Is this theme component sending the pdf to external interpreter?
I have “secure media” enabled because i want to avoid files being loaded by an external service..
---
### Author:  [@sharewoodsDavid](https://meta.discourse.org/u/sharewoodsDavid)
#### Post date: [November 4, 2021, 6:52pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/61 "2021-11-04T18:52:52Z")
I found out that this is because of the following code:
```plaintext
doc.pdf
```
If you replace the above code with the following:
```plaintext
doc.pdf
```
It will work
But I’m not sure how to fix this in the existing code.
---
### Author:  [@sharewoodsDavid](https://meta.discourse.org/u/sharewoodsDavid)
#### Post date: [November 4, 2021, 7:02pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/62 "2021-11-04T19:02:28Z")
@Johani
The error is associated with the following code, line 34 - 41:
```plaintext
const setUpPreviewType = (pdf) => {
if (previewMode === "Inline") {
const preview = createPreviewElement();
pdf.classList.add("pdf-attachment");
pdf.append(preview);
return preview;
}
```
---
### Author:  [@sharewoodsDavid](https://meta.discourse.org/u/sharewoodsDavid)
#### Post date: [November 4, 2021, 7:19pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/63 "2021-11-04T19:19:46Z")
This solution seems to work for all browsers.
---
### Author:  [@Benjamin\_D](https://meta.discourse.org/u/Benjamin_D)
#### Post date: [November 4, 2021, 9:50pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/64 "2021-11-04T21:50:51Z")
> [@sharewoodsDavid](#):
>
> The error is associated with the following code, line 34 - 41:
>
> ```plaintext
> const setUpPreviewType = (pdf) => {
> if (previewMode === "Inline") {
> const preview = createPreviewElement();
> pdf.classList.add("pdf-attachment");
> pdf.append(preview);
>
> ```
`pdf.parentNode.append(preview);` seems to do the trick (but in case of multiple pdfs, previews show below all links, not below each one)
---
### Author:  [@sharewoodsDavid](https://meta.discourse.org/u/sharewoodsDavid)
#### Post date: [November 5, 2021, 11:16am UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/65 "2021-11-05T11:16:18Z")
But if the parentNode is the paragraph, than this shouldn’t be an issue because the link and the iframe will be inside the paragraph tag.
So to bypass this issue you can just add a newline between the attachments:
```plaintext
[doc1.pdf|attachment](...)
[doc2.pdf|attachment](...)
```
and with your solution it will properly display the PDF preview on Chrome as well
---
### Author:  [@Johani](https://meta.discourse.org/u/Johani)
#### Post date: [November 5, 2021, 4:16pm UTC](https://meta.discourse.org/t/inline-pdf-previews/157649/66 "2021-11-05T16:16:57Z")
I just pushed some changes.
[https://github.com/discourse/discourse-pdf-previews/pull/6](https://github.com/discourse/discourse-pdf-previews/pull/6)
> [@nathank](#):
>
> What I want is for the pdf to be inline by default, and to open in a new tab if the space is put in the filename.
Yeah, that makes more sense than ignoring the file. Here’s how things will work after the update.
1. If you set the setting to “New Tab,” the component won’t attach any preview in posts. If you click the link, it will open the PDF in a new tab.
2. If you set the setting to “Inline,” the component will attach a preview in the post to all PDFs by default. If the file name starts with a space, it won’t attach the preview, but clicking the link will open the PDF in a new tab instead of downloading it.
> [@omarfilip](#):
>
> Chrome is again showing only gray boxes
> [@sharewoodsDavid](#):
>
> If you replace the above code with the following:
>
> ```plaintext
> doc.pdf
>
>
> ```
>
> It will work
Thanks for the debugging and details @sharewoodsDavid. It turns out that `