תצוגות מקדימות של PDF בקובץ

zogstrip · 15 ביולי,‏ 2026,‏ 8:47am

@tpetrov this is now fixed

github.com/discourse/discourse-pdf-previews

DEV: Move mobile-view check out of initialization (#60)

main ← fix-static-viewport-deprecation

merged 08:46AM - 15 Jul 26 UTC

ZogStriP

+5 -4

### What & why The component read `site.mobileView` inside its initializer, whi…ch runs while the application is still booting. Accessing the viewport that early is deprecated (`discourse.static-viewport-initialization`) — the value isn't reliable before boot and can't react to viewport changes. As a result, every admin on a site running this component saw a persistent **"[Admin Notice] … contains code which needs updating"** banner. ### Fix - Move the desktop-only guard into the `decorateCookedElement` callback so it is evaluated at render time instead of during initialization. - Read it from the modern `capabilities.viewport` service rather than the legacy mobile/desktop split. Since `site.mobileView` is defined as `!capabilities.viewport.sm`, behaviour is unchanged — previews remain desktop-only. See https://meta.discourse.org/t/367810 for the viewport guidance.

נושא		תגובות	צפיות
Discourse send PDF inline Plugin	11	1659	17 בפברואר,‏ 2026
Make PDFs open directly (not via download) by default Feature completed , pdf-previews	15	550	18 בפברואר,‏ 2026
Add configuration option to serve local PDF uploads inline Feature completed , pdf-previews	2	797	5 בספטמבר,‏ 2024
How to view .docs or .docx as preview or another tab in discourse Support pdf-previews	2	372	7 ביוני,‏ 2024
Regression - PDFs download initiated on click (should be open in new tab) Bug pdf-previews , fixed	1	99	10 ביוני,‏ 2026

תצוגות מקדימות של PDF בקובץ

נושאים קשורים