Excellent! Thanks @Johani. I can confirm it works in all 3 browsers now.
4 إعجابات
Fantastic - these are solid improvements and clearly a lot of work to achieve. Thanks for listening to us slightly annoying co-conspirators in the self-hosted world!
Does the Component now work with S3 uploads?
3 إعجابات
I haven’t tried it, but It should work if your bucket is configured correctly. This component makes a request to load the PDF
These types of requests made in JavaScript are blocked if the origin is not allowed access to the file. You then end up with a CORS error. If you check the console, you’ll probably see something along the lines of this.
There’s not much the component can do about this. It all has to be handled in your S3 configuration. The origin - your Discourse domain - must be allowed to make such requests to avoid CORS issues.
9 إعجابات
Thanks! I’ll bravely take the plunge back to S3 shortly.
Another suggestion: tab when space before filename
What I want is for the pdf to be inline by default, and to open in a new tab if the space is put in the filename. This gives authors the choice per pdf of inline vs tab rather than per component.
Perhaps the component setting should instead be “What default behaviour do you want?” and if a space is put in you get the other.
Or alternatively you could ask what the space should do (inline / tab / download).
إعجابَين (2)
Aargh! Chrome is again showing only gray boxes. FF and Safari are OK.
3 إعجابات
Is this theme component sending the pdf to external interpreter?
I have “secure media” enabled because i want to avoid files being loaded by an external service…
إعجاب واحد (1)
I found out that this is because of the following code:
<a class="attachment pdf-attachment" href="...pdf">doc.pdf
<iframe src="blob:..." height="500" loading="lazy" class="pdf-preview">
</iframe>
</a>
If you replace the above code with the following:
<a class="attachment pdf-attachment" href="...pdf">doc.pdf</a>
<iframe src="blob:..." height="500" loading="lazy" class="pdf-preview"></iframe>
It will work
But I’m not sure how to fix this in the existing code.
5 إعجابات
@Johani
The error is associated with the following code, line 34 - 41:
const setUpPreviewType = (pdf) => {
if (previewMode === "Inline") {
const preview = createPreviewElement();
pdf.classList.add("pdf-attachment");
pdf.append(preview);
return preview;
}
4 إعجابات
This solution seems to work for all browsers.
4 إعجابات
pdf.parentNode.append(preview); seems to do the trick (but in case of multiple pdfs, previews show below all links, not below each one)
3 إعجابات
But if the parentNode is the paragraph, than this shouldn’t be an issue because the link and the iframe will be inside the paragraph tag.
So to bypass this issue you can just add a newline between the attachments:
[doc1.pdf|attachment](...)
[doc2.pdf|attachment](...)
and with your solution it will properly display the PDF preview on Chrome as well
3 إعجابات
I just pushed some changes.
Yeah, that makes more sense than ignoring the file. Here’s how things will work after the update.
-
If you set the setting to “New Tab,” the component won’t attach any preview in posts. If you click the link, it will open the PDF in a new tab.
-
If you set the setting to “Inline,” the component will attach a preview in the post to all PDFs by default. If the file name starts with a space, it won’t attach the preview, but clicking the link will open the PDF in a new tab instead of downloading it.
All native browser PDF viewers have a download button, so you can download it from there if you want to.
Thanks for the debugging and details @sharewoodsDavid. It turns out that <iframe> tags inside <a> tags fails to validate
The element
iframemust not appear as a descendant of theaelement
So, your fix is on point. I made that change in the PR above.
If you want to add an element after another element, you can use after() like so
someElement.after(newElement)
If you want to add an element before another element, you can use insertBefore() like so
// parentNode: the parent of the element you want to insert before
// newNode: the element you want to insert
// referenceNode: the element you want to insert before
parentNode.insertBefore(newNode, referenceNode)
No. There are no external services involved in this. Here’s how it works.
- user visits a post with a PDF attachment
- user’s browser requests the attachment
- server sends it to the user’s browser
- the user’s browser reads it using the built-in PDF viewer
That’s it.
7 إعجابات
Perfect - thanks @Johani. Confirming it works in Chrome, FF, and Safari. 
3 إعجابات
هذا رائع! شكراً جزيلاً لك. لقد قمت بتثبيته ويعمل! هذا بالضبط ما كنت أبحث عنه.
5 إعجابات
هل سيكون هذا بأثر رجعي على ملفات PDF التي تم نشرها بالفعل في المنتدى؟
إعجابَين (2)
لقد اختبرت للتو على موقعي التجريبي، ويبدو أنه يعمل مع المواقع الحالية أيضًا، دون الحاجة إلى ‘إعادة بناء HTML’. 
6 إعجابات
لقد رأيت تحديثًا في المصدر الأسبوع الماضي، لذا أفترض أن هذه المكونات تعمل. لكن للأسف لم تعمل معي أبدًا على أي متصفح. هل هذا بسبب إعدادات الوسائط الآمنة ربما؟ هل أنا الوحيد الذي لا يستطيع تشغيل هذا أم أن هذه مشكلة شائعة؟
إعجابَين (2)
لم تعمل معي أبداً أيضاً.
إعجابَين (2)
تعمل المكونة بشكل جيد. ما هي المشكلة/الخطأ الذي تراه؟
3 إعجابات
لم أر سوى رابط تنزيل عادي لملف. لم أبدأ في التعمق أكثر لأنه لم يكن مهمًا بالنسبة لي، كان سيكون لطيفًا الحصول عليه، لا شيء آخر. لذا، آسف ولكن لا يمكنني توضيح هذا الأمر أكثر.
تعديل
حسنًا، لقد تحققت مرة أخرى - كانت آخر مرة منذ بعض الوقت.
يعرض DiscourseHub هذا (iPad)، ولا توجد أخطاء في سجلات Discourse:
ولكن عندما حاولت استخدام سفاري، عرضت الصفحة الأولى فقط، وليس الثانية.
إعجاب واحد (1)