Installer is wrongly checking for just 5MB of free space

waverider · December 20, 2020, 10:13pm

I think free_disk will contain KB and hence it will check if there are 5MB of storage space available, instead if 5GB, so it should be -lt 5000000.

  free_disk="$(df /var | tail -n 1 | awk '{print $4}')"
  if [ "$free_disk" -lt 5000 ]; then

github.com

discourse/discourse_docker/blob/master/discourse-setup#L189


    total_swap=`free -g --si | awk ' /Swap:/ {print $2} '`
    if [ "$total_swap" -lt 2 ]; then
      echo "Failed to create swap: are you root? Are you running on real hardware, or a fully virtualized server?"
      exit 1
    fi
  fi
fi
free_disk="$(df /var | tail -n 1 | awk '{print $4}')"
if [ "$free_disk" -lt 5000 ]; then
  echo "WARNING: Discourse requires at least 5GB free disk space. This system"
  echo "does not appear to have sufficient disk space."
  echo
  echo "Insufficient disk space may result in problems running your site, and"
  echo "may not even allow Discourse installation to complete successfully."
  echo
  echo "Please free up some space, or expand your disk, before continuing."
  echo
  echo "Run \`apt-get autoremove && apt-get autoclean\` to clean up unused"

I’ve checked this on Ubuntu 18.04 and 20.04.

sam · December 20, 2020, 11:02pm

This seems legitimate @pfaffman, thoughts?

pfaffman · December 21, 2020, 12:06am

Hmm. Has it really been that broken for that long?!

I’ll check (and fix) this and the maxmind issue discussed elsewhere this week. And, I hope, post my multisite without a reverse proxy script.

Edit: oh! I see. It just wasn’t really checking anything. It’s pretty improbable that anyone doing a new install has less than 5gb of space anyway, and presumably the disk space check in launcher actually works, so maybe there’s no reason to do a test here at all.