Installer is wrongly checking for just 5MB of free space

I think free_disk will contain KB and hence it will check if there are 5MB of storage space available, instead if 5GB, so it should be -lt 5000000.

  free_disk="$(df /var | tail -n 1 | awk '{print $4}')"
  if [ "$free_disk" -lt 5000 ]; then

I’ve checked this on Ubuntu 18.04 and 20.04.

4 Likes

This seems legitimate @pfaffman, thoughts?

Hmm. Has it really been that broken for that long?!

I’ll check (and fix) this and the maxmind issue discussed elsewhere this week. And, I hope, post my multisite without a reverse proxy script.

Edit: oh! I see. It just wasn’t really checking anything. It’s pretty improbable that anyone doing a new install has less than 5gb of space anyway, and presumably the disk space check in launcher actually works, so maybe there’s no reason to do a test here at all.

2 Likes