Internal 404 links not rendering the 404 page

(Johan Jatko) #1

To reproduce:

  1. Visit topic with link leading to a Discourse 404 page
  2. Refresh the topic with F5 (not really neccesary)
  3. Click the 404-link

This should change the link in the navigation bar, but the page doesn’t change with it unless you right-click it and press “copy link”, and then press it again.

Here are some 404 links to test with:

This was tested with Firefox 28.

(David Maxwell) #2

If I understand you correctly, it behaves similarly in Chrome - you click the link, it doesn’t do anything but change the URL in the address bar - F5 will refresh the page and show the not found page. Even more fun if you you click multiple links, as the history is affected, so when you DO hit F5, all those links will then be included for the back button…

(Kane York) #3

And then, because it was done with pushState(), it tries to do the back-navigation with only JS, but it seems that Ember isn’t loaded, because it doesn’t work.

(Hey, that’s strange… I remember something about explicitly loading Ember in 404 pages? Or maybe it was 403 pages.)

(Jeff Atwood) #4

Is there anything we can do about this @eviltrout?

(Johan Jatko) #5

I think these links also fail:

(Robin Ward) #6

Our Ember app never needed the ability to deal with 404s until now, which is pretty interesting considering how long it’s been around! I’ve just added support for 404 links within the Javascript app and now this should be fixed!

(Jeff Atwood) #7