Invitations do not expire

Contribute Bug

AI-generated summary

A discussion arose about invitations not expiring as expected on Discourse. hiddenseal observed that users were able to accept invitations well past their due date and theorized that users might be signing up on the website with the same email address associated with the expired invitation. jessiinoslen replicated this issue and confirmed the theory. The problem was later fixed by techAPJ via a commit to the Discourse repository, resolving the issue of invitations not expiring as intended.

1

The discourse shows people accepting my invitation well past their due date.

I’m not sure whether people actually accept the 1+ year-old invite links, or they simply sign up on the website, and because there was an expired invite on their email address, they’re considered to “have accepted the invitation.”

In any case, it doesn’t seem like an invitation should be considered accepted if a person signed up on their own a year after the original invitation expired.

3 Likes
2

Hey @hiddenseal – I was able to replicate this on my end. It looks like your theory of the person signing up with the same email is on the nose. Here is how I replicated it:

  1. I sent an invitation to an old email and waited for the invite to expire
  2. I clicked on the link and it said the invite token had expired →
    expired
    expired1910×949 38 KB
  3. From the expired token page I just clicked ‘Sign Up’ on the top right corner and completed the sign up as usual.
  4. I checked the ‘Redeemed’ tab under the ‘Invites’ menu along with the site notifications and it said they accepted the invitation →
    expired 4
    expired 41912×947 105 KB
6 Likes
5

Fixed via:

https://github.com/discourse/discourse/commit/d600c36036c5c3b53787067682128ae2d86311bf

Thanks for reporting this issue @hiddenseal & @jessii :+1:

6 Likes
6

This topic was automatically closed after 23 hours. New replies are no longer allowed.