Invited to topic wrong referenced user

AI-generated summary

A user, jesselperry, reported a bug where the invitation email for a topic incorrectly states that the topic creator invited the user, instead of the actual inviter. They suspected it was due to the use of %{username} in the USER_NOTIFICATIONS.INVITED_TO_TOPIC_BODY text content, which should be changed to %{invitee_name}.

techAPJ confirmed that this was a recent regression and fixed it via a commit on GitHub. However, techAPJ was unable to reproduce a subsequent issue reported by jesselperry, where manually changing the text content resulted in a โ€œtranslation missingโ€ error.

I noticed when I invite a user to a topic, it incorrectly says in the email that the topic creator invited the user (instead of correctly stating that I invited the user)

Oddly it seems very similar to this bug referenced back in '13: Invite notification email is from topic OP author, not inviter

It would seem that in the USER_NOTIFICATIONS.INVITED_TO_TOPIC_BODY Text Content in Discourse, %{username} just needs to be changed to %{invitee_name}

If I knew how to submit a PR I would :confused:

1๊ฐœ์˜ ์ข‹์•„์š”

Ok, now a bug when I try to manually change this myself in Discourse :frowning:

The email arrives just with this in the body: translation missing: en.user_notifications.invited_to_topic_body

Hmm can you repro this @techapj?

1๊ฐœ์˜ ์ข‹์•„์š”

Yes, this was a recent regression. Fixed via:

https://github.com/discourse/discourse/commit/51d194cc212cae261a09ca243825a2532c0d35d1

Thanks for reporting it. :thumbsup:


I am not able to repro this.

3๊ฐœ์˜ ์ข‹์•„์š”

This topic was automatically closed after 2 days. New replies are no longer allowed.