# Is the wizard supposed to not let you skip adding icons?

**URL:** https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417
**Category:** Bug
**Created:** [20 בנובמבר,‏ 2018,‏ 7:46pm UTC](https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417 "2018-11-20T19:46:30Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [20 בנובמבר,‏ 2018,‏ 7:46pm UTC](https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417/1 "2018-11-20T19:46:30Z")

</div>

When I run the wizard (I updated in the past several hours) and get to the icons page (`/wizard/steps/icons`), it won’t let me click next, presumably because I have not uploaded any icons.

Is this what’s intended? It doesn’t seem very nice to force people to come up with artwork. 🙂

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [20 בנובמבר,‏ 2018,‏ 7:48pm UTC](https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417/2 "2018-11-20T19:48:59Z")

</div>

Hmm no that would be a regression @j.jaffeux

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [21 בנובמבר,‏ 2018,‏ 11:59am UTC](https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417/5 "2018-11-21T11:59:16Z")

</div>

@tgxworld can you have a look please?

The stacktrace shows:

> NoMethodError in StepsController#update undefined method `encoding’

which happens in `app/models/upload.rb:185`

The params sent to the controller are:

```ruby
<ActionController::Parameters {"fields"=>{"favicon"=>{"id"=>"101286", "user_id"=>"2770", "original_filename"=>"logo-small.png", "filesize"=>"13844", "width"=>"350", "height"=>"349", "url"=>"//cdck-file-uploads-global.s3.dualstack.us-west-2.amazonaws.com/meta/original/3X/b/3/b33be9538df3547fcf9d1a51a4637d77392ac6f9.png", "created_at"=>"2018-07-18T04:13:01.619Z", "updated_at"=>"2018-07-18T04:13:01.684Z", "sha1"=>"b33be9538df3547fcf9d1a51a4637d77392ac6f9", "origin"=>"", "retain_hours"=>"", "extension"=>"png", "thumbnail_width"=>"350", "thumbnail_height"=>"349"}, "apple_touch_icon"=>{"id"=>"76914", "user_id"=>"3", "original_filename"=>"meta-logo-small.png", "filesize"=>"4614", "width"=>"350", "height"=>"349", "url"=>"//cdck-file-uploads-global.s3.dualstack.us-west-2.amazonaws.com/meta/original/3X/a/c/ac166452701ce353fa6c8865e99879e8cacfb960.png", "created_at"=>"2017-08-16T14:25:06.738Z", "updated_at"=>"2017-08-16T14:25:07.250Z", "sha1"=>"ac166452701ce353fa6c8865e99879e8cacfb960", "origin"=>"", "retain_hours"=>"", "extension"=>"png", "thumbnail_width"=>"350", "thumbnail_height"=>"349"}}, "controller"=>"steps", "action"=>"update", "id"=>"icons"} permitted: false>

```

Which is kind of unexpected given I don’t have anything set:

 ![01](https://global.discourse-cdn.com/meta/original/3X/5/2/52829c664e309b6790ca68632ceb3179fe36e3a8.png)

If you still think it’s not related to uploads let me know, I will dig deeper in my recent changes.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [22 בנובמבר,‏ 2018,‏ 6:20am UTC](https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417/7 "2018-11-22T06:20:45Z")

</div>

Thanks for reporting @pfaffman 🙂

This is fixed in

[https://github.com/discourse/discourse/commit/596e09aaf9c45abe3758ebaea6787e34844bf365](https://github.com/discourse/discourse/commit/596e09aaf9c45abe3758ebaea6787e34844bf365)

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [24 בנובמבר,‏ 2018,‏ 10:00am UTC](https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417/8 "2018-11-24T10:00:01Z")

</div>

This topic was automatically closed after 2 days. New replies are no longer allowed.