# "Join Group" button should invoke the login dialog when not signed in. Currently does nothing at all

**URL:** https://meta.discourse.org/t/join-group-button-should-invoke-the-login-dialog-when-not-signed-in-currently-does-nothing-at-all/55215
**Category:** Bug
**Created:** [5 Enero, 2017 13:42 UTC](https://meta.discourse.org/t/join-group-button-should-invoke-the-login-dialog-when-not-signed-in-currently-does-nothing-at-all/55215 "2017-01-05T13:42:42Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![ChrisBeach](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/chrisbeach/32/214628_2.png) [@ChrisBeach](https://meta.discourse.org/u/ChrisBeach)
#### Post date: [5 Enero, 2017 13:42 UTC](https://meta.discourse.org/t/join-group-button-should-invoke-the-login-dialog-when-not-signed-in-currently-does-nothing-at-all/55215/1 "2017-01-05T13:42:42Z")

</div>

When I visit a group page like [SE23 Forum - Forest Hill & Honor Oak](https://se23.life/groups/2017_parents) as a non-signed in user, the “Join Group” button currently doesn’t do anything when clicked.

Should bring up the login dialog IMO (and ensure that the newly-signed-up user is added to group member list after sign-up).

One for the Groups Master @tgxworld I think 🙂

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [5 Enero, 2017 13:47 UTC](https://meta.discourse.org/t/join-group-button-should-invoke-the-login-dialog-when-not-signed-in-currently-does-nothing-at-all/55215/2 "2017-01-05T13:47:44Z")

</div>

I’ll have a look first thing tml. 🙂

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [6 Enero, 2017 03:58 UTC](https://meta.discourse.org/t/join-group-button-should-invoke-the-login-dialog-when-not-signed-in-currently-does-nothing-at-all/55215/3 "2017-01-06T03:58:41Z")

</div>

Fixed in

[https://github.com/discourse/discourse/commit/a4e7657bbfae3ba2cdbf0f3d1925915f20ae71b9](https://github.com/discourse/discourse/commit/a4e7657bbfae3ba2cdbf0f3d1925915f20ae71b9)

with tests.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [6 Enero, 2017 03:58 UTC](https://meta.discourse.org/t/join-group-button-should-invoke-the-login-dialog-when-not-signed-in-currently-does-nothing-at-all/55215/4 "2017-01-06T03:58:44Z")

</div>


