Js.max - please clarify how it is used


(Anton) #1

This one is too generic:

js.max

The English text is:

max

And it can be translated to Russian in ~5 different ways depending on context.


(Sam Saffron) #2

Where is this used? We should translate the bigger sentence, not the joiner.


(Kane York) #3
kane@newlaptop:~/projects/discourse$ grep -R "['\"]max['\"]" ~/projects/discourse/{app,lib}
/home/kane/projects/discourse/app/models/topic.rb:    highest = exec_sql("select coalesce(max(post_number),0) as max from posts where topic_id = ?", topic_id).first['max'].to_i

Nowhere at all.


(Anton) #4

Does it mean it will be removed from Transifex sooner or later and I should not care about it?


(Régis Hanol) #5

The API on the client-side doesn’t require single/double quotes (eg. {{i18n max}}). It is actually used somewhere :wink:


(Sam Saffron) #6

The translation string here should be count_max … not max by its lonesome.

Also, “5 max” is very weird sentence. “max of 5” … is way clearer.


(Régis Hanol) #7

That is now fixed :dromedary_camel:

https://github.com/discourse/discourse/commit/baee5c95ace4937f1024c5c1355a55486b681af2


(Régis Hanol) #8