# Latest Update - Broken House Ads

**URL:** https://meta.discourse.org/t/latest-update-broken-house-ads/315082
**Category:** Bug
**Tags:** advertising, fixed
**Created:** [July 5, 2024, 4:18am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082 "2024-07-05T04:18:32Z")
**Posts on this page:** 7
**Page:** 1

<div class="post-metadata">

### Author: ![Vaping\_Community](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vaping_community/32/89248_2.png) [@Vaping\_Community](https://meta.discourse.org/u/Vaping_Community)
#### Post date: [July 5, 2024, 4:18am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/1 "2024-07-05T04:18:33Z")

</div>

## Version: 3.3.0.beta4-dev

# UPDATE

Removed all house ads and site is working normally again, see reply to this post for the error given in console

###########################################################

Since I upgraded our site, I have had a list of problems

- Login button on mobile doesn’t work
- Topics are blank
- Users experiencing problems all over including not being able to read messages
- Main menu not working (no simple access to admin)

# Errors

> Job exception: undefined method `id’ for nil:NilClass 4:52 am

> Failed to warm up pretty text: JavaScript was terminated (either by timeout or explicitly) /var/www/discourse/vendor/bundle/ruby/3.2.0/gems/mini\_racer-0.9.0/lib/mini\_racer.rb:242:in `call\_unsafe’ /var 4:55 am

> Job exception: undefined method `id’ for nil 5:11 am

I’ve tried rebuilding via SSH but no joy

All help appreciated, thanks

---

<div class="post-metadata">

### Author: ![Vaping\_Community](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vaping_community/32/89248_2.png) [@Vaping\_Community](https://meta.discourse.org/u/Vaping_Community)
#### Post date: [July 5, 2024, 4:26am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/2 "2024-07-05T04:26:47Z")

</div>

Found this via console

```plaintext
house-ad.js:104 Uncaught (in promise) 
TypeError: Cannot read properties of undefined (reading 'category_ids')
    at house-ad.js:104:1
    at Array.filter (<anonymous>)
    at house-ad.js:102:1
    at Array.forEach (<anonymous>)
    at e.didInsertElement (house-ad.js:96:1)
    at e.r [as didInsertElement] (index.js:361:1)
    at e._trigger (core_view.js:55:1)
    at e.r (index.js:361:1)
    at e._trigger (ember-events.js:145:1)
    at e.r (index.js:361:1)
    at ze.didCreate (index.js:2102:1)
    at jt.commit (runtime.js:3965:1)
    at Mt.commit (runtime.js:4062:1)
    at Nt (runtime.js:4082:1)
    at gr._renderRoots (index.js:4916:1)
    at gr._renderRootsTransaction (index.js:4960:1)
    at gr._renderRoot (index.js:4905:1)
    at gr._appendDefinition (index.js:4830:1)
    at gr.appendOutletView (index.js:4820:1)
    at invoke (backburner.js.js:282:1)
    at h.flush (backburner.js.js:197:1)
    at p.flush (backburner.js.js:358:1)
    at B._end (backburner.js.js:798:1)
    at B._boundAutorunEnd (backburner.js.js:523:1)

```

---

<div class="post-metadata">

### Author: ![Vaping\_Community](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vaping_community/32/89248_2.png) [@Vaping\_Community](https://meta.discourse.org/u/Vaping_Community)
#### Post date: [July 5, 2024, 4:38am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/5 "2024-07-05T04:38:10Z")

</div>

Resetting House ads (removed and reinstated) fixed this problem

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [July 5, 2024, 5:31am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/7 "2024-07-05T05:31:13Z")

</div>

I have a PR up with the fix:

[https://github.com/discourse/discourse-adplugin/pull/214](https://github.com/discourse/discourse-adplugin/pull/214)

However, I am unable to repro this issue on my dev server. @Vaping_Community do you have repro steps for this issue so that I dig even deeper?

---

<div class="post-metadata">

### Author: ![Vaping\_Community](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vaping_community/32/89248_2.png) [@Vaping\_Community](https://meta.discourse.org/u/Vaping_Community)
#### Post date: [July 5, 2024, 7:32am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/8 "2024-07-05T07:32:05Z")

</div>

This is all I can give you, I hope it helps

**Note:** Between Posts had 6 ads in place

 ![Screenshot 2024-07-05 082838](https://global.discourse-cdn.com/meta/original/4X/6/a/c/6ac751a58848c1cbb6ba9f5a19730f60623a536e.png)

## Example of advert

All adverts use the same format

```plaintext
<a class="fcbanner" target="_blank" href="https://vapeview.co/?r=vcuk"><img src="https://vapingcommunity.co.uk/uploads/default/original/3X/2/d/2d2e817cadaadd3e8b5ae638af67f580763848f7.jpeg"/></a>

```

## CSS

```plaintext
.fcbanner img {
    width: 700px;
}

```

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [July 5, 2024, 11:55am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/9 "2024-07-05T11:55:32Z")

</div>

Thanks for the details, but still unable to repro this issue on my dev setup. Anyways, can you try updating the plugin source code and see if everything looks good to you? The PR merged above should fix the issues you were seeing.

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [July 8, 2024, 2:30am UTC](https://meta.discourse.org/t/latest-update-broken-house-ads/315082/10 "2024-07-08T02:30:40Z")

</div>

This topic was automatically closed after 2 days. New replies are no longer allowed.