Launcher cleanup's fs download doesn't seem to count?


(Allen - Watchman Monitoring) #1

I’m upgrading my discourse to 1.3.3 and decided I’d run /launcher cleanup first.

The cleanup downloaded the new 1.3.3 filesystem, which was a surprise, but not a big deal.

however, running ./launcher rebuild app downloaded 1.3.3 again, which took a while, again.

Is this expected? normal?


Launcher cleanup side effect - bad?
(Jeff Atwood) #2

Are you sure? Cleanup downloads a small docker image of its own specific to cleanup. So maybe you’re mixing that up with the actual discourse image?


(Allen - Watchman Monitoring) #3

This is the version of launcher I was using:

:/var/discourse# git pull
remote: Counting objects: 32, done.
remote: Compressing objects: 100% (32/32), done.
remote: Total 32 (delta 17), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (32/32), done.
From https://github.com/discourse/discourse_docker
   844ca25..0f60d88  master     -> origin/master
Updating 844ca25..0f60d88
Fast-forward

Here’s the cleanup:

/var/discourse# ./launcher cleanup

WARNING: We are about to start downloading the Discourse base image
This process may take anywhere between a few minutes to an hour, depending on your network speed

Please be patient

Unable to find image 'discourse/discourse:1.3.3' locally
1.3.3: Pulling from discourse/discourse
6d28225f8d96: Pulling fs layer
a8475e067366: Pulling fs layer
d888351c5c02: Pulling fs layer
a3ed95caeb02: Pulling fs layer
a3ed95caeb02: Waiting
6d28225f8d96: Verifying Checksum
6d28225f8d96: Download complete
a3ed95caeb02: Verifying Checksum
a3ed95caeb02: Download complete
6d28225f8d96: Pull complete
a8475e067366: Download complete
d888351c5c02: Verifying Checksum
d888351c5c02: Download complete
a8475e067366: Pull complete
d888351c5c02: Pull complete
a3ed95caeb02: Pull complete
Digest: sha256:f16e87c5244b4eb889f6a836219c342c0e702688166c31523863421eeb838cc6
Status: Downloaded newer image for discourse/discourse:1.3.3

The following command will
- Delete all docker images for old containers
- Delete all stopped and orphan containers

Are you sure (Y/n): y
Starting Cleanup (bytes free 28378092)
Unable to find image 'samsaffron/docker-gc:latest' locally

latest: Pulling from samsaffron/docker-gc
0f4d770cd333: Pull complete 
a3ed95caeb02: Pull complete 
6a2ea02ca5be: Pull complete 
bc4c30afebbb: Pull complete 
Digest: sha256:1efd5febba28f881c815c37005b09c67fce0fa62d583b82790b0a0fe82cad999
Status: Downloaded newer image for samsaffron/docker-gc:latest
Finished Cleanup (bytes free 32893876)


Then right after that I:

# ./launcher rebuild app

WARNING: We are about to start downloading the Discourse base image
This process may take anywhere between a few minutes to an hour, depending on your network speed

Please be patient

Unable to find image 'discourse/discourse:1.3.3' locally
1.3.3: Pulling from discourse/discourse
6d28225f8d96: Pulling fs layer
a8475e067366: Pulling fs layer
d888351c5c02: Pulling fs layer
a3ed95caeb02: Pulling fs layer
a3ed95caeb02: Waiting
6d28225f8d96: Verifying Checksum
6d28225f8d96: Download complete
a3ed95caeb02: Verifying Checksum
a3ed95caeb02: Download complete
6d28225f8d96: Pull complete
a8475e067366: Verifying Checksum
a8475e067366: Download complete
d888351c5c02: Verifying Checksum
d888351c5c02: Download complete
a8475e067366: Pull complete
d888351c5c02: Pull complete
a3ed95caeb02: Pull complete
Digest: sha256:f16e87c5244b4eb889f6a836219c342c0e702688166c31523863421eeb838cc6
Status: Downloaded newer image for discourse/discourse:1.3.3
Ensuring launcher is up to date
Fetching origin
Launcher is up-to-date
Stopping old container
+ /usr/bin/docker stop -t 10 app
app
cd /pups && git pull && /pups/bin/pups --stdin
From https://github.com/SamSaffron/pups
   d72d1f3..2b8776d  master     -> origin/master
 * [new tag]         v1.0.0     -> v1.0.0
 * [new tag]         v1.0.1     -> v1.0.1
Updating d72d1f3..2b8776d
Fast-forward

I don’t have a constraint on bandwidth in my situation, but it’d be nice not to have to wait for both.


(Kane York) #4

I’m guessing it was downloaded as part of the launcher script then promptly deleted by the cleanup (as it wasn’t being used).


(Jeff Atwood) #5

Yeah that might be a bug, then.


Latest automatic version upgrade failed