./launcher should validate container name before bootstrap begins

(lid) #1

I just happened to create a container with the name

and then I ran the bootstrap command

“./launcher bootstrap appDev”

And right before the end of the bootstrap log I see

2014/07/23 04:32:05 Invalid repository name (appDev), only [a-z0-9-_.] are allowed
Successfully bootstrapped, to startup use ./launcher start appDev

Starting the container will not work either, because the bootstrap actually failed

“.launcher start appDev”

error log

Unable to find image 'local_discourse/appDev' locally
2014/07/23 04:37:51 Invalid repository name (appDev), only [a-z0-9-_.] are allowed
docker@boot2docker:/var/docker$ only [a-z0-9-_.] are allowed
-sh: only: not found
docker@boot2docker:/var/docker$ 2014/07/23 04:32:05 Invalid repository name (appDev), only [a-z0-9-_.] are allowed
-sh: syntax error: unexpected "("

I think .laucnher should check that the container name is valid before it start the bootstrapping process to save a lot of time.

(Jeff Atwood) #2

Yes this has bugged me for a long time with /launcher @sam it does not sanity check the container stuff (does this container name even exist?) at all before plowing ahead. Feels very amateurish when that happens.

(Sam Saffron) #3

Sorted per:

/var/docker# ./launcher start banana
Config file was not found, ensure containers/banana.yml exists

Available configs ( logster, samsaffron )

(Sam Saffron) #4