Link External Counter and CTRL+LMB does not open in new tab


(lid) #1

###Description of issue
An external link counter CTRL+LMB ( left mouse button) will not open link in new tab and will increase the counter by one on each click while the CTRL button is down.

Instruction to reproduce

press down the control button on the keyboard and use the mouse left button and click on the gray circle next to external link.

Expected behavior: assuming that the external counter is part of the clickable link when using ctrl+LMB the link should open in a new tab.


####secondary issue
-2. counter increase when user right click on counter or associated link, multiple times
this can make sense if the user is using the context menu to open tab, so this might not be an issue per say.
but counter should probably only increase once as long as the user is on the page.


(Jeff Atwood) #2

Client side only issue. Will not persist on refresh and other users will not see it. Cosmetic.


(lid) #3

Indeed the counter is a minor issue that is why I marked it as secondary.

The main issue is the Ctrl+left mouse button click does not open the link in new tab.


(lid) #4

@sam fixed
https://github.com/discourse/discourse/commit/e798705aecef1941889e51de78450ea420ec611e


(Sam Saffron) #5