# Links improperly escaped

**URL:** https://meta.discourse.org/t/links-improperly-escaped/125325
**Category:** Bug
**Created:** [August 9, 2019, 12:22pm UTC](https://meta.discourse.org/t/links-improperly-escaped/125325 "2019-08-09T12:22:35Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![cori](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cori/32/124112_2.png) [@cori](https://meta.discourse.org/u/cori)
#### Post date: [August 9, 2019, 12:22pm UTC](https://meta.discourse.org/t/links-improperly-escaped/125325/1 "2019-08-09T12:22:35Z")

</div>

Our platform uses links that contain `#!` in the address, and recently it seems like Discourse is improperly escaping those links when displayed. [https://support.glitch.com/t/glitch-freezes-when-trying-to-work-on-projects/13349?u=cori](https://support.glitch.com/t/glitch-freezes-when-trying-to-work-on-projects/13349?u=cori) is an example post, the top link there in edit view is `https://glitch.com/edit/#!/equinox-watch` but the boxed link is `https://glitch.com/edit/#%21%2Fequinox-watch`, which ends up failing.

This _seems_ like relatively new behavior. I suppose blacklisting our domain in OneBox might help, but I’m curious if something changed or if there’s any other mechanism to prevent this.

---

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [August 9, 2019, 12:33pm UTC](https://meta.discourse.org/t/links-improperly-escaped/125325/2 "2019-08-09T12:33:59Z")

</div>

This sounds like same as [Evernote oneboxes have extra %25 for each % in URL](https://meta.discourse.org/t/evernote-oneboxes-have-extra-25-for-each-in-url/125291)

---

<div class="post-metadata">

### Author: ![cori](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cori/32/124112_2.png) [@cori](https://meta.discourse.org/u/cori)
#### Post date: [August 9, 2019, 4:52pm UTC](https://meta.discourse.org/t/links-improperly-escaped/125325/3 "2019-08-09T16:52:19Z")

</div>

The presentation is a little different, but it does indeed seem like the same root cause, thanks!

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [August 12, 2019, 3:17am UTC](https://meta.discourse.org/t/links-improperly-escaped/125325/4 "2019-08-12T03:17:35Z")

</div>

Fixed via:

[https://github.com/discourse/onebox/commit/7bfbc3d7471b20ea5210fe5d1fe56b9e945bc29d](https://github.com/discourse/onebox/commit/7bfbc3d7471b20ea5210fe5d1fe56b9e945bc29d)

The fix will be deployed on your instance soon. Thanks for reporting this issue @cori 👍

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [August 12, 2019, 3:18am UTC](https://meta.discourse.org/t/links-improperly-escaped/125325/5 "2019-08-12T03:18:03Z")

</div>


