The Category Banner theme component now shows URLs in a different color. These weren’t black before, I believe they had a different color. Is this intended?
AI-generated summary
Users are discussing a change in the Category Banner theme component where links now appear in black, which affects readability depending on the background color. AquaL1te noticed the change and questioned if it was intentional, sharing a screenshot showing the new styling. HamMan2118 observed that on dark backgrounds, links appear white, suggesting the color may depend on the scheme used. Moin explained that links inherit the primary color from the color scheme, while banner text uses the foreground color set in category settings. They also noted that changes to @mentions are affecting other links and shared examples of poor contrast, including a suggestion to remove the background from @mentions for better readability Moin. awesomerobot provided two commits addressing the issue. However, Moin reported that group mentions and mentions of non-existent users still have styling problems. bryce confirmed a fix for those cases with a new commit, including a screenshot showing improved styling. The discussion centers on ensuring consistent, readable link styling across different color schemes and mention types.
Interesting. On a black background, the links show as white. I wonder if it is dependent on the color that is used? (i.e a lighter color = black hyperlink)
The link uses the primary color specified by the color scheme. I think the normal text in the banner uses the foreground color which is chosen in the category settings.
The change for @mentions seems to effect other links as well
https://github.com/discourse/discourse-category-banners/commit/7da1900e78ba47886f44f9ab09036c3dd6b66f56
Right now the banner combined with a light color scheme looks like this:
Maybe it would be better to remove the background of the @mention:
1 Like
Couple fixes for it here:
2 Likes
2 Likes
Group mentions and non-existent user mentions should now be fixed with this commit:
1 Like