Standort-Plugin 🌍

[omarfilip]

@Richie

Not sure where else Discourse uses it though

Heh - yes - I didn’t want to go that route specifically for that reason.

[Richie (Richie Rich)]

I’ve changed mine…

It produces this effect:

[omarfilip]

The unintended consequence is found in the Users List:

[merefield (Robert)]

Sorry for the delay.

There’s no API for this afaics.

It’s just taking the value from the title:

https://github.com/paviliondev/discourse-locations/blob/c947297e8177f751b0f92dc15c52baecd6d4d75f/assets/javascripts/discourse/widgets/map.js.es6#L93

[ckshen]

Has anyone come across this before? that the map just occupies only a portion of the map space? It always displayed just fine, until we updated the plugin.

SF Bay Area, NorCal, Tahoe

[merefield (Robert)]

Does this resolve if you remove the Layouts plugin?

[ckshen]

Oddly, the map doesn’t show up (all blank) when I remove the layouts plugin. I was originally thinking it might be a CSS issue but the issue persists after I removed all CSS.

Which is real odd, because your map at Pavilion looks just fine.

[merefield (Robert)]

Cannot repro. Check for a Theme clash?

[Richie (Richie Rich)]

Latest update to core seems to have killed this stone dead:

Clicking the user map, or the map icon on a user card causes a self inflicted dos

It then just keeps going, killing the browser stone dead within a handful of seconds:

Same on the user map page:

I’ve had to disable the plugin completely this morning.

[Richie (Richie Rich)]

Related perhaps?

Why is location plugin using so much CPU?

I rebuilt the container with the latest test-passed from today, and suddenly all the CPU cycles are used up. The site becomes real slow. The server pretty much only has Discourse running. What’s this openvpn user running the Ruby/ unicorns? Is it the same as the Discourse unicorns? [image] Assuming this is intended and desired, how can I free up some cpu cycles so the site doesn’t run so slow? Sidekiq is showing barely anything running in the background. No users are on other than me.

[merefield (Robert)]

Sorry, not going to get much time to look at this right now, moving house and outside the support period double whammy.

I would first check this is not something else which is impacting the server, it may not be Locations at all …

I cannot presently see anything going wrong with Locations on current build, there’s nothing in logs.

Please take a look at what might be stealing performance.

[Richie (Richie Rich)]

@merefield

I would first check this is not something else which is impacting the server, it may not be Locations at all …

I’d say it’s probably the 4,000+ network calls being made to map.json every time someone tries to view a users location

@merefield

not going to get much time to look at this right now

No worries, I’ve disabled the plugin for now.

[merefield (Robert)]

Working fine on my instance. Just updated. Noticed a load of uncached resources at first. Fine now. To do with redis upgrade?

[Richie (Richie Rich)]

@merefield

To do with redis upgrade?

I genuinely don’t know

Would that cause the thousands and thousands of network calls though?

[merefield (Robert)]

Every single avatar for all the users in scope? (for example). Every piece of map required.

[Richie (Richie Rich)]

No, sorry, I meant, would it cause the thousands of network calls per minute to map.json that I was seeing?

[merefield (Robert)]

A 429 that’s being ignored, perhaps? If an asset is needed again, but denied, it may still go after it.

Yeah, not sure about the 200’s … what provider are you using?

[Richie (Richie Rich)]

When I clicked on a user card, then on the map icon for that single user, it instantly started firing hundreds and hundreds of network calls to map.json

Over 1,000 calls to map.json were sent in under 60 seconds, just from my browser alone.

To the point where my desktop PC browser locked up completely and when I opened my discourse on my phone I instantly got the “slow down, too many requests from this IP” message.

[Richie (Richie Rich)]

@Richie

Over 1,000 calls to map.json were sent in under 60 seconds

Probably more, but my browser died at that point

[Richie (Richie Rich)]

I tried again.

Same thing - kills itself instantly:

And:

etc.

On the off chance it was browser related, I tried Chrome instead of firefox.

Chrome seems to handle the issue slightly better and it got to over 10,000 network requests to map.json in under sixty seconds, at which point my entire PC started locking up - not just the browser:

Don’t worry about it @merefield I’ve turned it off again