# Login Button form attribute

**URL:** https://meta.discourse.org/t/login-button-form-attribute/109828
**Category:** Bug
**Created:** [February 22, 2019, 2:52pm UTC](https://meta.discourse.org/t/login-button-form-attribute/109828 "2019-02-22T14:52:51Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![mcnesium](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mcnesium/32/133983_2.png) [@mcnesium](https://meta.discourse.org/u/mcnesium)
#### Post date: [February 22, 2019, 2:52pm UTC](https://meta.discourse.org/t/login-button-form-attribute/109828/1 "2019-02-22T14:52:51Z")

</div>

In [this commit](https://github.com/discourse/discourse/commit/8c91d418ddc240cf6f1faf3561c140b1bdbce130) the login button has been added a `form` attribute to, but [that commit](https://github.com/discourse/discourse/commit/14f3594f9f39dce7f6a5dda44287560b0a6e53e8) removed it again. This prevents some password managers from auto submitting the login form.

Related:

[https://meta.discourse.org/t/login-form-is-invalid-html/87735](https://meta.discourse.org/t/login-form-is-invalid-html/87735)

[https://github.com/browserpass/browserpass/issues/261](https://github.com/browserpass/browserpass/issues/261)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [February 23, 2019, 5:54am UTC](https://meta.discourse.org/t/login-button-form-attribute/109828/2 "2019-02-23T05:54:05Z")

</div>

I think @zogstrip ran into problems with that, but we should re-assign the work.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [February 23, 2019, 8:29am UTC](https://meta.discourse.org/t/login-button-form-attribute/109828/3 "2019-02-23T08:29:38Z")

</div>

This should be fixed in:

[https://github.com/discourse/discourse/pull/7056](https://github.com/discourse/discourse/pull/7056)

@tgxworld it seems like removing this was not made on purpose, please correct me if there was a reason.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [February 25, 2019, 5:00pm UTC](https://meta.discourse.org/t/login-button-form-attribute/109828/4 "2019-02-25T17:00:00Z")

</div>

This topic was automatically closed after 2 days. New replies are no longer allowed.