Login form is invalid HTML


#1

The Login button of the login form is not within the HTML <form> element. While this makes the HTML code invalid, it also prevents password managers from auto-submitting the form. Please see this issue for example.


(Régis Hanol) #2

Submit buttons does not have to be a child of the HTML <form> element.

I recently added the form attribute to the Login button to help password managers.


#3

I see. Thank you for adding this. Will this only be in Discourse v2.0 or also backported?


(Régis Hanol) #4

That would be one more reason to upgrade to the latest version :wink:


#5

I will take this advice with me to all the Discourse admins out there :wink:


(Régis Hanol) #6