# Mailing list mode - broken experience in transition from 1.5-\>1.6

**URL:** https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863
**Category:** Bug
**Created:** [26 mei 2016 om 19:17 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863 "2016-05-26T19:17:46Z")
**Posts on this page:** 12
**Page:** 1

<div class="post-metadata">

### Author: ![jedc768](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jedc768/32/116532_2.png) [@jedc768](https://meta.discourse.org/u/jedc768)
#### Post date: [26 mei 2016 om 19:17 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/1 "2016-05-26T19:17:47Z")

</div>

Relevant topic - [Mailing list mode keeps reverting to daily updates](https://meta.discourse.org/t/mailing-list-mode-keeps-reverting-to-daily-updates/44793/1)

I help run a Discourse forum where we had actively encouraged users to check the box saying “Send me an email for every post” - aka, set `mailing_list_mode = True`.

With the **new** mailing list mode, those users all have `mailing_list_mode = True`, but apparently by default have `mailing_list_mode_frequency = 0`. As a result, they’re no longer getting the individual emails per post that they expected.

**Two issues -**

1 - users that previously had `mailing_list_mode = True` should automatically be opted-in and have the `mailing_list_mode_frequency` set to the relevant value. (Right?)

2 - what’s the right way to make that change at scale for our users?

cc/ @ryanwanger

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [26 mei 2016 om 19:21 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/2 "2016-05-26T19:21:06Z")

</div>

Hmm we should handle this better @erlend_sh @zogstrip

---

<div class="post-metadata">

### Author: ![tobiaseigen](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tobiaseigen/32/539204_2.png) [@tobiaseigen](https://meta.discourse.org/u/tobiaseigen)
#### Post date: [26 mei 2016 om 19:29 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/3 "2016-05-26T19:29:28Z")

</div>

I experienced this as well, though in the end only a handful of people had mailing list mode turned on at all and were affected. I was able to write to them directly to sort it out. So it was a fairly easy transition once the [settings bug was fixed](https://meta.discourse.org/t/mailing-list-mode-keeps-reverting-to-daily-updates/44793/8). Unfortunately one of those people was my CEO who was not especially happy about it.

To find out who had mailing list mode turned on and the frequency, I used this [data explorer](https://meta.discourse.org/t/32566?silent=true) query and then exported to csv.

> SELECT user\_id,mailing\_list\_mode,mailing\_list\_mode\_frequency from user\_options

---

<div class="post-metadata">

### Author: ![ryanwanger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ryanwanger/32/116450_2.png) [@ryanwanger](https://meta.discourse.org/u/ryanwanger)
#### Post date: [26 mei 2016 om 19:43 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/4 "2016-05-26T19:43:15Z")

</div>

Just to clarify, would just setting mailing\_list\_mode\_frequency = 1 for all the people who had mailing\_list\_mode set to true be the correct fix?

---

<div class="post-metadata">

### Author: ![tobiaseigen](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tobiaseigen/32/539204_2.png) [@tobiaseigen](https://meta.discourse.org/u/tobiaseigen)
#### Post date: [26 mei 2016 om 19:45 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/5 "2016-05-26T19:45:50Z")

</div>

Yes - I think it’s fair to assume that is correct. When I look at the [data explorer](https://meta.discourse.org/t/32566?silent=true) results and compare against the user preferences, it matches up.

---

<div class="post-metadata">

### Author: ![gdpelican](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gdpelican/32/81308_2.png) [@gdpelican](https://meta.discourse.org/u/gdpelican)
#### Post date: [26 mei 2016 om 20:06 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/7 "2016-05-26T20:06:28Z")

</div>

I’ve put in a PR to set the frequency default correctly for folks who haven’t upgraded yet:  
[https://github.com/discourse/discourse/pull/4241/files](https://github.com/discourse/discourse/pull/4241/files)

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [27 mei 2016 om 01:46 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/8 "2016-05-27T01:46:19Z")

</div>

Hmm this only fixes brand new account going forward, there is the huge problem of “history” which is now wrong ☹

To get out of this pickle we are going to have to add a once off migration that sets everything 1 on that table, which means we break any people that changed stuff. @neil released a new image yesterday so, ouch.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [27 mei 2016 om 02:10 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/10 "2016-05-27T02:10:13Z")

</div>

This is fixed per:

[https://github.com/discourse/discourse/commit/8c3a0b44baea3388db4b719766a961d3a2114fc9](https://github.com/discourse/discourse/commit/8c3a0b44baea3388db4b719766a961d3a2114fc9)

Sorry but this is the best we can do.

- The new default for “mailing list mode frequency” is daily, site admins can change.

- The “mailing list” warning screen is gone cause it no longer makes sense

- After running the migration all old accounts that had mailing list enabled will be switched to the “every email” frequency, to match old behavior.

---

<div class="post-metadata">

### Author: ![fefrei](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/fefrei/32/119538_2.png) [@fefrei](https://meta.discourse.org/u/fefrei)
#### Post date: [27 mei 2016 om 08:16 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/11 "2016-05-27T08:16:20Z")

</div>

Should this fix also go into the beta branch? I’m holding off from upgrading right now because of this issue.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [27 mei 2016 om 08:24 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/12 "2016-05-27T08:24:32Z")

</div>

maybe, @neil can you perhaps do another bump early in your morning with today’s fixes?

---

<div class="post-metadata">

### Author: ![neil](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/neil/32/102150_2.png) [@neil](https://meta.discourse.org/u/neil)
#### Post date: [27 mei 2016 om 15:28 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/13 "2016-05-27T15:28:45Z")

</div>

Version has been bumped!

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [28 mei 2016 om 02:10 UTC](https://meta.discourse.org/t/mailing-list-mode-broken-experience-in-transition-from-1-5-1-6/44863/14 "2016-05-28T02:10:39Z")

</div>

This topic was automatically closed after 24 hours. New replies are no longer allowed.
