This is looking great! 
Can you confirm params are working as well?
This is looking great! 
Can you confirm params are working as well?
Yes, they show up in the UI if the query takes params
I was wrong; params are not currently working. I will look into that today.
The adapter for queries is an admin adapter, so non-admin users cannot access the query store. I added endpoints that non-admins can hit to get the query JSON, but it looks like that JSON is not being converted into Query models (of course, how would they be), and so the params logic is not being run. I am assuming I need a non-admin adapter for queries?
I see an issue in screenshot #3: you may want to bring back the “save without running” button, now that there’s meaningful non-query data to be saved.
Ah, didn’t spot that you had imported the green confirm button as well.
The green confirm button saves without running, and I would think that having the “Save Changes and Run” button should do exactly that.
Are you saying that the “Save Changes and Run” behavior should change, and not run the query?
Group members can now run queries that take params!
I am not able to run the specs (with bundle exec rspec), and thus have not written any tests for the new actions I created. Can anyone point me to what I am missing? The error message is uninitialized constant DataExplorer
Try LOAD_PLUGINS=1 RAILS_ENV=test bundle exec rspec
Yep, that does it. Thanks!
Note I usually just use bin/rake autospec it does that automatically, all you need to do is save plugin.rb or something.
@sam ,
What do you think about the Include query plan? checkbox for group reports?
It seems like something that group members would not need to have access to, and should be removed. Is that a correct assumption?
Agree this is info they don’t really need
This has been removed, and the PR is ready for review.
2 specs fail, but they fail on master as well. I could look into fixing those in this PR if it would be appreciated ![]()
Absolutely welcome!! We will be reviewing it shortly, thanks for the awesome work.
この機能を使おうとしているのですが、フォームに追加したグループが保存されず、つまりフォームを保存する方法がないようです。
モデレーターと共有したいクエリのスクリーンショットを以下に示します。
リフレッシュ前にクエリを編集して「保存」しても、この問題は解消されません。また、システムデフォルトのクエリを含む他のクエリを共有しようと試みましたが、同様に機能しませんでした。
更新情報です──別のサイトでも同様の動作が確認できたため、サイト固有の問題のようです。
いずれにせよ、UI が破損している場合の回避策を見つけました。API を介してクエリにグループを追加するには、https://example.com/admin/plugins/explorer/queries/<query_id> に POST リクエストを送信してください。
ヘッダーを設定し、管理者ユーザーの API キーを使用します。
Api-UsernameApi-KeyContent-Type – application/jsonリクエストボディを設定します。
query[group_ids][] – このクエリへのアクセスを許可するグループ ID をカンマ区切りで指定した文字列今日か月曜日に確認します。
緊急性はありません。
@j.jaffeux さん、ありがとうございます!
これは以下のコミットで修正されるはずです:
ご報告ありがとうございます。
このトピックは最後の返信から 2 日後に自動的に閉鎖されました。新しい返信は許可されていません。