# Menu toggle for different reply modes

**URL:** https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133
**Category:** UX
**Created:** [February 28, 2017, 9:45pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133 "2017-02-28T21:45:19Z")
**Posts on this page:** 11
**Page:** 2

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [February 7, 2018, 6:57pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/37 "2018-02-07T18:57:44Z")

</div>

@david concerning a bug mentioned by @awesomerobot in whispers:

[https://global.discourse-cdn.com/meta/original/3X/2/2/22c5517cdcb7531041bc6af8cf3de8ed04586c8e.mp4](https://global.discourse-cdn.com/meta/original/3X/2/2/22c5517cdcb7531041bc6af8cf3de8ed04586c8e.mp4)

I linked it to the presence plugin which is I think not expecting we could create a new topic when we are browsing a topic. And will then subscribe to a null channel to messageBus in this case here : [https://github.com/discourse/discourse/blob/master/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6#L79](https://github.com/discourse/discourse/blob/master/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6#L79)

I think we shouldn’t try to subscribe to anything if action is not reply or edit. What do you think ?

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [February 7, 2018, 7:30pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/38 "2018-02-07T19:30:51Z")

</div>

> [@j.jaffeux](#):
>
> I think we shouldn’t try to subscribe to anything if action is not reply or edit. What do you think ?

That sounds reasonable, there’s no need for any presence features on new topics.

The code has changed a lot since I wrote it, so I couldn’t say offhand where that change would need to be made. Longer term it would definitely be good to move a lot of this presence logic into message-bus as @sam mentioned a while ago

> [@sam](#):
>
> The big thing here is around adding “native” presence support for message bus.
> 
> At the moment there is a fiddly 50-100 lines of code you need to add to create a “presence” channel, the plan is just to have this native so we don’t need to carry all this luggage around.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [February 7, 2018, 9:22pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/39 "2018-02-07T21:22:49Z")

</div>

> [@awesomerobot](#):
>
> would anyone be opposed to making this stand out slightly more as a button?

I think it should be quite subtle, so I prefer the current design. This is an extreme power user feature, not something we want to call a lot of extra attention to.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [February 8, 2018, 11:26am UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/40 "2018-02-08T11:26:25Z")

</div>

I just pushed a commit which should largely improve the situation. Let me know what you think @sam

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [February 8, 2018, 12:52pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/41 "2018-02-08T12:52:21Z")

</div>

Looks so much better!

---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [February 8, 2018, 1:03pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/42 "2018-02-08T13:03:31Z")

</div>

“Toggle whisper” is missing in the dropdown when I click the topic’s reply button. It’s only visible after clicking a post’s reply button. Is that intentional?

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [February 8, 2018, 1:50pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/43 "2018-02-08T13:50:47Z")

</div>

Should be fixed thanks!

---

<div class="post-metadata">

### Author: ![featheredtoast](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/featheredtoast/32/116994_2.png) [@featheredtoast](https://meta.discourse.org/u/featheredtoast)
#### Post date: [February 8, 2018, 8:22pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/44 "2018-02-08T20:22:24Z")

</div>

Love the improvements!

BTW, here’s a PR for the suggestions on tab indexing (here implemented as index 8, after the ‘cancel’ focus) and adding :focus styling – Something like this would suit my needs as a keyboard user.

[https://github.com/discourse/discourse/pull/5575](https://github.com/discourse/discourse/pull/5575)

---

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [February 8, 2018, 11:27pm UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/45 "2018-02-08T23:27:58Z")

</div>

> [@awesomerobot](#):
>
> One small thing: would anyone be opposed to making this stand out slightly more as a button?

That was my first reaction.

> [@codinghorror](#):
>
> This is an extreme power user feature, not something we want to call a lot of extra attention to.

I disagree. Replying privately to a public message seems like a fairly useful thing to do (but maybe we don’t want to encourage private conversation?), and the only way that I know to do that is with the 🏴.

And when I was teaching with Discourse, reply-as-linked-topic was very useful for people to start a new topic with their solution to the exercise.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [February 9, 2018, 12:20am UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/46 "2018-02-09T00:20:27Z")

</div>

> [@pfaffman](#):
>
> Maybe we don’t want to encourage private conversation?

Correct, we don’t want to do that.

---

<div class="post-metadata">

### Author: ![erlend\_sh](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/erlend_sh/32/119475_2.png) [@erlend\_sh](https://meta.discourse.org/u/erlend_sh)
#### Post date: [February 28, 2018, 8:57am UTC](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133/47 "2018-02-28T08:57:25Z")

</div>



[Previous page](https://meta.discourse.org/t/menu-toggle-for-different-reply-modes/58133.md?page=1)
