# Method typeClass() in site-setting.js.es6 incorrectly handles multiword setting types

**URL:** https://meta.discourse.org/t/method-typeclass-in-site-setting-js-es6-incorrectly-handles-multiword-setting-types/32572
**Category:** Bug
**Created:** [2015年八月27日 05:38 UTC](https://meta.discourse.org/t/method-typeclass-in-site-setting-js-es6-incorrectly-handles-multiword-setting-types/32572 "2015-08-27T05:38:47Z")
**Posts on this page:** 3
**Page:** 1

<div class="post-metadata">

### Author: ![dmitry\_fedyuk](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dmitry_fedyuk/32/293153_2.png) [@dmitry\_fedyuk](https://meta.discourse.org/u/dmitry_fedyuk)
#### Post date: [2015年八月27日 05:38 UTC](https://meta.discourse.org/t/method-typeclass-in-site-setting-js-es6-incorrectly-handles-multiword-setting-types/32572/1 "2015-08-27T05:38:47Z")

</div>

The problem line:

> <https://github.com/discourse/discourse/blob/v1.4.0.beta10/app/assets/javascripts/admin/components/site-setting.js.es6#L24>

Surely, it must be:

```plaintext
return componentType.replace(/_/g, '-');

```

For now, `typeClass()` incorrectly handles multiword setting types, for example: `my_setting_type` =\> `my-setting_type` because JavaScript `String.replace()` method replaces only the first occurence by default.

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [2015年八月27日 08:49 UTC](https://meta.discourse.org/t/method-typeclass-in-site-setting-js-es6-incorrectly-handles-multiword-setting-types/32572/2 "2015-08-27T08:49:36Z")

</div>

Thanks. Just pushed a fix 🐢

[https://github.com/discourse/discourse/commit/95c8ec50a872fab0e37ef7da7f2678542003c504](https://github.com/discourse/discourse/commit/95c8ec50a872fab0e37ef7da7f2678542003c504)

(_next time you can submit a PR if you want_)

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [2015年八月27日 08:49 UTC](https://meta.discourse.org/t/method-typeclass-in-site-setting-js-es6-incorrectly-handles-multiword-setting-types/32572/3 "2015-08-27T08:49:39Z")

</div>