Missing badges translations


(Camille Roux) #1

Default badges are partially translated:


(Sebastien Miquerolle) #2

Translated in Transifex. It’s strange that the left name doesn’t the same that the real name.

Maybe that the db/fixture was run without translation and doesn’t update it after. I don’t know if it’s the same with text like Tos/Guidelines.


(Alper Buluc) #3

Sorry for reviving this post but I am having exactly the same problem with discourse 1.5.0.beta6 (tr_TR locale) . Is there a way to fix this?

Thanks.


(RĂ©gis Hanol) #4

FYI: I just merged @gerhard’s PR :heart_eyes:


(Grégoire Menuel) #5

Hi !

It seems that the bug is still present for the notification bubble :

Any idea of how to fix this ?


(Gerhard Schlager) #6

That’s a known bug and it’s quite hard to fix. :cry:


#7

Is the site’s locale also unknown at the time of badge granting?

@gerhard As you seemed to already take a look at it, do you have any tips on how I can get started at finding a fix for this bug?


(Gerhard Schlager) #8

The site’s locale is known, but it is currently not used. It should be display_name instead of name.

I could only think of one fix that wouldn’t affect the performance of badge granting: Add the users.locale column to every badge query and use that value for creating the badge notifications like I’ve done for manually granted badges.