Missing indenting for github onebox


(Sam Saffron) #1

Indenting is messed up here:

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/models/topic_tracking_state.js#L199-L222

line 214 is indented in source as is line 204, etc …

also … line 219 -> 222 are missing in action

cc @Lid


(lid) #2

Thanks for reporting,

  1. We need to add
pre.onebox code ol.lines li {
   white-space: pre;
}

I will push a pr

2.I think max lines is set to 20


(Sam Saffron) #3

OK, I added the rule, I wonder if truncating at 20 is too aggressive.

https://github.com/discourse/discourse/commit/a6fcacec6b4316fea167622105d2b197b6ee3807


(Sam Saffron) #4