Moderation yes button after suspending user

Ah I see now, thanks for the additional detail, this required some untangling… I assumed this was something we missed earlier with review queue changes, but it’s a side effect of another change that wasn’t meant to impact the review queue.

The original issue was that with must_approve_users on, users with a review queue item that had already been handled but who were still unapproved couldn’t be approved from their admin page, because approval only worked on pending items. The fix allowed user approval even with already handled queue items. That fixed the admin page, but it also produced the approve button on handled items in the review queue.

So rather than fixing the context, that approve button shouldn’t appear as you said. I’ve got a fix on the way that will hide that in the review queue again:

1 Like