Hello！ I want to modify controller with plugin api, but it failed with a warning like: [THEME xxx] “controller:full-page-search” was already cached in the container. Changes won’t be applied. my code: function modifySearchTypes(api) { api.modifyClass("controller:full-page-search", { pluginId: "modify-search-types", init() { this._super(...arguments); this.set("searchTypes", [ { name: I18n.t("search.type.default"), id: SEARCH_TYPE_DEFAULT }, { name: this.siteSettings.tagging_enabled ? I18n.t("search.type.categories_and_tags") : I18n.t("search.type.categories"), id: SEARCH_TYPE_CATS_TAGS, }, ]); this.selected = []; }, }); } export default { name: "modify-search-types", initialize() { withPluginApi("0.10.0", modifySearchTypes); }, }; How can I deal with it? Thank you very much!

See api.modifyClass sometimes(!) not working - #12 by RGJ

[image] Richard - Communiteq: api.modifyClass 有时（！）不起作用 - RGJ 的 #12 Thank you! However, code below still failed and print this warning. function modifySearchTypes(api) { api.modifyClass("controller:full-page-search", { pluginId: "modify-search-types", init() { this._super(...arguments); this.set("searchTypes", [ { name: I18n.t("search.type.default"), id: SEARCH_TYPE_DEFAULT }, { name: this.siteSettings.tagging_enabled ? I18n.t("search.type.categories_and_tags") : I18n.t("search.type.categories"), id: SEARCH_TYPE_CATS_TAGS, }, ]); this.selected = []; }, }); const searchController = api.container.lookup("controller:full-page-search"); } export default { name: "modify-search-types", initialize() { withPluginApi("0.10.0", modifySearchTypes); }, };

I override template of full page search with a new one in my theme component. Does it have any effect？

[image] Using modifyClass to change core behavior Developer Guides For advanced themes and plugins, Discourse offers the modifyClass system. This allows you to extend and override functionality in many of core’s javascript classes. When to use modifyClass modifyClass should be a last resort, when your customization cannot be made via Discourse’s more stable customization APIs (e.g. plugin-api methods, plugin outlets, transformers). Core’s code can change at any time. And therefore, customizations made via modifyClass could break at any time. When using this A…

modifyClass failed with a warning

Development

david (David Taylor) April 18, 2023, 10:40am 6

Topic		Replies	Views
api.modifyClass sometimes(!) not working Bug	13	2427	April 18, 2023
Add class to full page search result items? Development	2	785	April 18, 2023
Using modifyClass to change core behavior Developer Guides	6	2778	March 4, 2026
Adding pluginId to modifyClass when a mixin is used Development	0	575	May 4, 2022
modifyClass gives TypeError undefined? Development	0	513	October 14, 2022

modifyClass failed with a warning

Related topics