# More data in user approval

**URL:** https://meta.discourse.org/t/more-data-in-user-approval/323565
**Category:** Feature
**Tags:** approval
**Created:** [August 27, 2024, 1:50pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565 "2024-08-27T13:50:46Z")
**Posts on this page:** 12
**Page:** 1

<div class="post-metadata">

### Author: ![ganncamp](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ganncamp/32/106199_2.png) [@ganncamp](https://meta.discourse.org/u/ganncamp)
#### Post date: [August 27, 2024, 1:50pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/1 "2024-08-27T13:50:46Z")

</div>

As one strategy to combat a current spam wave, we’ve enabled user approval.

When I’m looking at a as-yet-unapproved user, I see only the info they filled in in the signup form:

 ![Selection_1998](https://global.discourse-cdn.com/meta/original/4X/1/6/a/16a25b8d82845e5ea868c4d612e05ec3f636f621.png)

But we’ve realized that the problem is coming from a specific subset of IPs and those IPs generally resolve to one of two companies. So for nearly every user, I end up clicking through to see the IP and then doing a lookup on it.

 ![Selection_1999](https://global.discourse-cdn.com/meta/original/4X/5/1/3/5137f10f75d79959307a3b39a3d18c0c0829d7e3.png)

And then I go back to the review queue to either approve or delete

It would be really helpful if the IP and the lookup button were presented in the review queue. :awthanks:

---

<div class="post-metadata">

### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger)
#### Post date: [August 27, 2024, 1:56pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/2 "2024-08-27T13:56:03Z")

</div>

I think we have theme component for that you can install. 👍

[https://github.com/discourse/discourse-review-ip-lookup](https://github.com/discourse/discourse-review-ip-lookup)

Not sure it has a meta topic?

---

<div class="post-metadata">

### Author: ![ganncamp](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ganncamp/32/106199_2.png) [@ganncamp](https://meta.discourse.org/u/ganncamp)
#### Post date: [August 27, 2024, 2:09pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/4 "2024-08-27T14:09:26Z")

</div>

> [@JammyDodger](#):
>
> Not sure it has a meta topic?

Or a description in the repo 😅

Nonetheless, I’ve installed it, but I’m not seeing any change, even in the component preview. Even after a hard refresh.

 ![Selection_2003](https://global.discourse-cdn.com/meta/original/4X/9/2/c/92c4a98b9549a88713ccb834741c5678a8d15a1f.png)  
Did I miss a button somewhere?

 ![Selection_2002](https://global.discourse-cdn.com/meta/original/4X/4/3/6/436d84ec6fba0cfac1790628dae598ba4c0a8895.png)

---

<div class="post-metadata">

### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger)
#### Post date: [August 27, 2024, 2:18pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/5 "2024-08-27T14:18:30Z")

</div>

Hmm 🤔 It seems to be working for me on my test site:

 ![Untitled](https://global.discourse-cdn.com/meta/original/4X/f/4/e/f4e2cf9eb38d67da7d7a3d52b4c5a7b1f326e1b3.png)

Though now you mention it, I’m not sure I see it in our review queue here on meta (and it is installed).

---

<div class="post-metadata">

### Author: ![ganncamp](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ganncamp/32/106199_2.png) [@ganncamp](https://meta.discourse.org/u/ganncamp)
#### Post date: [August 27, 2024, 2:20pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/6 "2024-08-27T14:20:10Z")

</div>

And… you’re seeing it on a post and not (necessarily) on a user?

ETA: Altho… I’m not sure where in your screenshot I should be looking to see the IP lookup?

---

<div class="post-metadata">

### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger)
#### Post date: [August 27, 2024, 2:22pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/8 "2024-08-27T14:22:30Z")

</div>

No, I’ve spotted what it is for meta. It doesn’t show on reviewables that now have deleted users (I remember it borking out when it tried previously). I can see it if I scroll to an eligible one.

Let me check a user approval one on my test site. 👀

(and I put a better screenshot in the post above)

* * *

No, you’re right. It doesn’t seem to be appearing for a user approval reviewable. Let me see if that’s intended…

---

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [August 27, 2024, 2:30pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/10 "2024-08-27T14:30:11Z")

</div>

> [@ganncamp](#):
>
> Or a description in the repo 😅

I really think that a linting rule requiring something in `about.json` and/or not having the default `readme.md` would be a good idea. Maybe have it triggered by setting a non-default version number? And then a Best Practice would be to set some version number before the thing was deployed (otherwise, one would be required to make up something that’s completely bogus before they made their first commit?).

---

<div class="post-metadata">

### Author: ![fzngagan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/fzngagan/32/259349_2.png) [@fzngagan](https://meta.discourse.org/u/fzngagan)
#### Post date: [September 12, 2024, 8:25am UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/13 "2024-09-12T08:25:39Z")

</div>

Hey @ganncamp  
I’ve updated the theme component to bring it at par with the Discourse updates. Although the support for User Reviewable isn’t there still as the Backend doesn’t support sending the IP address of the User Reviewable currently. I’ll discuss internally and let you know what we think about this change.

---

<div class="post-metadata">

### Author: ![Overgrow](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/overgrow/32/478189_2.png) [@Overgrow](https://meta.discourse.org/u/Overgrow)
#### Post date: [September 12, 2024, 11:30am UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/14 "2024-09-12T11:30:12Z")

</div>

Would it be possible to style it properly for the mobile too? Currently the ip lookup modal is completely out of the viewport in the post review screen. Thanks!

---

<div class="post-metadata">

### Author: ![ganncamp](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ganncamp/32/106199_2.png) [@ganncamp](https://meta.discourse.org/u/ganncamp)
#### Post date: [September 12, 2024, 2:17pm UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/15 "2024-09-12T14:17:46Z")

</div>

@fzngagan your PR title is

> FIX: mordernise js, prevent display on ReviewableUser ([#5](https://github.com/discourse/discourse-review-ip-lookup/pull/5))

Did you really want to _prevent_ display on users?

Because it’s already not there.

Also, when you said this:

> [@fzngagan](#):
>
> bring it at par with the Discourse updates

I kinda assumed that meant adding a repo description 😅

---

<div class="post-metadata">

### Author: ![fzngagan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/fzngagan/32/259349_2.png) [@fzngagan](https://meta.discourse.org/u/fzngagan)
#### Post date: [September 18, 2024, 7:09am UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/16 "2024-09-18T07:09:37Z")

</div>

> [@ganncamp](#):
>
> Did you really want to _prevent_ display on users?

Just until the backend provides the IP address. Not meaning to keep it that way.

> [@ganncamp](#):
>
> I kinda assumed that meant adding a repo description 😅

I’ll get to it soon.

---

<div class="post-metadata">

### Author: ![fzngagan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/fzngagan/32/259349_2.png) [@fzngagan](https://meta.discourse.org/u/fzngagan)
#### Post date: [January 18, 2025, 8:15am UTC](https://meta.discourse.org/t/more-data-in-user-approval/323565/17 "2025-01-18T08:15:52Z")

</div>

Hi @ganncamp  
The good news is, this feature is [merged into core Discourse](https://github.com/discourse/discourse/pull/30688) so you no longer need the theme component for this.
