I’m experimenting with shadow DOM in a Discourse plugin I’m writing and noticed that mousetrap.js is not stopping callbacks for events that originate in the shadow DOM. For example, pressing u in an input element triggers the Discourse shortcut for history back navigation; thus, stopping me from fil…

It would be great if you could get this fixed upstream. That would make our lives a lot easier, because we use yarn for that dependency and we’d like to avoid monkey patching. Please feel free to ping us or create a PR to update our dependency when a new version with the fix has been released.

I asked whether they want a new pull request because I don’t want to just hijack the existing pull request although it is stale for three years. We’ll see.

I submitted a pull request upstream: Shadow DOM: Stop callbacks from inside an open shadow tree by kleinfreund · Pull Request #438 · ccampbell/mousetrap · GitHub

Oh, I just noticed that we are using a fork of mousetrap because we had to apply a patch that hasn’t been merged yet . :see_no_evil: So, yeah, I guess you could send the pull request to our fork if there’s no reaction in the upstream project in a reasonable timeframe.

@kleinfreund FYI, I have merged the upstream changes on our fork of mousetrap should you wish to revisit the PR above.

I talked to the maintainer and asked whether they’re willing to review a pull request getting everything into order so that my initial pull request can get merged without failing tests. So I’m currently waiting for the review on those preparations. This would hopefully lay the groundwork for Discour…

The issue described in the original post is fixed in Mousetrap.js. Since the issue that leads to Discourse maintaining a fork of Mousetrap is not addressed, yet, it would be nice if someone could update discourse/mousetrap to include the recent changes to ccampbell/mousetrap .

Mousetrap.js لا يوقف استدعاءات التراجع بشكل صحيح للأحداث الصادرة من Shadow DOM

مطور

pmusaraj (Penar Musaraj) 25 مارس 2019، 2:13م 12

Thanks for the nudge @kleinfreund, our fork is updated and the update has been applied to core: DEV: Update Mousetrap to 1.6.3 · discourse/discourse@4452332 · GitHub

5 إعجابات

الموضوع		الردود	مرات العرض
Shadow tree navigation doesn’t go through Ember router Dev	2	775	10 ديسمبر 2018
Click event listener for dynamically pushed html Dev	1	315	19 ديسمبر 2022
Tracking a topic using the keyboard shortcut tracks other topics too Bug keyboard-shortcuts	15	1027	6 أبريل 2020
Shortcuts messing with canvas focus Support keyboard-shortcuts	1	345	2 يوليو 2021
Cannot grow/shrink composition pane with touch Feature	3	898	24 نوفمبر 2016

Mousetrap.js لا يوقف استدعاءات التراجع بشكل صحيح للأحداث الصادرة من Shadow DOM

الموضوعات ذات الصلة