🌍 New Calendar Feature: Show Local Time

News and Events Announcements
21

can we drop the leading zero :hugs:

It is a big improvement imo.

3 Likes
22

Ah, I missed that you were talking about repeating events sorry!

2 Likes
24

So, I have worked on this task for a while, since the last week, I see it can be structured into three sections and one question:

  1. Avoid duplications and noisiness in from → to ranges:
    • current year, no times (00:00):
      • same week/month range: Mon, Oct 6 → Fri, Oct 10 || Mon, Oct 6 → Mon, Oct 20
      • different months range: Mon, Oct 6 → Thu, Nov 6
    • current year, with times:
      • same day range: Mon, Oct 6 12:00 AM → 1:00 AM
    • different years, no times: Mon, Oct 6 → Tue, Jan 6, 2026
  2. Show local time based on checked checkbox (in OP)
  3. I observed some inconsistencies, when we display dates within range two days before and one day after today:
    • with time: Yesterday/Today/Tomorrow 8:00 PM
    • without time: Monday...Sunday
  4. Sometimes timezone is shown in the end of datetime: Today 2:00 PM → 4:00 PM (UTC). Question: in which cases do we want to show timezone in brackets?

https://github.com/discourse/discourse/pull/33291/files#diff-2e077b606bd687089f93f9b13e8ee5c273827c8a9bcf96dd291a1d960ebbfd16R231-R236

3 Likes
25

I have two related PRs:

https://github.com/discourse/discourse-calendar/pull/745

https://github.com/discourse/discourse/pull/33291

@nat, looping you in, since you worked on this feature years ago:

https://github.com/discourse/discourse/pull/18500

https://github.com/discourse/discourse/commit/1631394826e03073f99caa990811f261590d3257

  1. In which cases we should show a timezone name in brackets after the from/to date/time?

  2. What are the expectations to show: weekday name Monday...Sunday or Yesterday/Today/Tomorrow?

    I’d go with:

    • Yesterday/Today/Tomorrow: for -1 day<-Today->+1 day
    • Monday...Sunday: within current week or -3 days<-Today->+3 days

    Presence of time should not be a decision factor of which of two options above to show, as it is now:

    • no time: Monday...Sunday
    • with time: Yesterday/Today/Tomorrow
2 Likes
26

We are ready to merge the first PR. It is not ideal, since fixing edge cases, listed in my previous post might follow.

https://github.com/discourse/discourse-calendar/pull/745

3 Likes