Newly added posts can never be considered read


(Kane York) #1

These posts were added while I was viewing the topic. However, after vigorous scrolling, the blue ‘unread’ dots do not go away.

Note: This is a long-standing bug that was surfaced by the blue dots.


Read indicators! Yes! But they're not always clearing
(Jeff Atwood) #2

Eat the blue dots! EAT THEM!


(Sam Saffron) #3

I have no repro for this, I tested locally. There must be something else in play.

What are the exact steps to repro? (use 2 accounts on try)


(Kane York) #4

I don’t see the blue dots on try… That’s pretty useful for making sure that the bug is there.

Also, this is an issue that’s been around for a while, with the symptom being a grey circle with a 1.


(Sam Saffron) #5

I have seen the bug, just need a repro, its tricky.

I wonder if focus tracking is breaking under certain conditions. (if we think we are not in focus we send no events)


(Kane York) #6

It’s possible that I sometimes spend large amounts of time reading with the browser unfocused, because on Ubuntu by default the mousewheel follows cursor.

But… hmmm…


(Sam Saffron) #7

Found the bug at last, this is why it just stops tracking, will fix up these safeguards.

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/screen_track.js#L150-L153


(Sam Saffron) #8

OK,

I think I fixed this:


(Kane York) #9

Looks awesome, thanks.


(Sam Saffron) #10

Deployed on meta, flag to reopen if you can repro on meta.


(Sam Saffron) #11