No loading spinner when revisiting topics


(Sam Saffron) #1
  1. Click a topic from topic list
  2. You see a nice spinner
  3. Click back
  4. Click topic again
  5. No spinner shows up

cc @eviltrout


(Jeff Atwood) #2

Yeah, this is what I was thinking of when I said regression. Could be the CSS way isn’t working in this case. We might want to backport this fix, whatever it is, @eviltrout


(Robin Ward) #3

I don’t think it was a regression – basically we didn’t handle the loading case when a route was entered that returned a promise instead of a dummy object that wasn’t loaded yet.

I’ve fixed it by adding a generic loading template. A side effect of this is that more routes might show the loading spinner than did previously, if they return promises. We can tweak this if we don’t like it.


(cpradio) #4

I’d prefer that, especially if they are performing an entire page load. I’ve seen several scenarios previously that show no indication, so maybe this will address that. :smile:

Granted, I haven’t been annoyed with it enough to report it… :wink:


(Sam Saffron) #5