I am trying to save custom fields for a post that needs review. When I approve the post, the custom fields don’t get saved. I checked the :approved_post event and the custom fields aren’t getting set in the payload. How to preserve custom fields for reviewable posts. Also, I used NewPostManager, …

Can you show us some code? Ideally the minimal amount we can use to reproduce this issue.

I’m fixing an issue with events plugin where the events data in the post_custom_field doesn’t get saved if the category is set to require approval for topics. I reffered to the polls plugin and there it seems that the custom fields are being set on :appoved_post. this is the snippet from polls. N…

This is interesting because I would not expect the polls to work here either. The args passed to manager are not automatically put into the reviewable’s payload. I suspect there’s a bug here with polls and queued posts. I suspect validate_polls is never called after approval. @Roman can you look in…

I confirm this is a bug. is_poll is not being stored inside the payload, making the callback useless. Here’s a PR to fix it: https://github.com/discourse/discourse/pull/8009 I also added a new interface so we can extend the list of allowed attributes from a plugin.

Thanks a lot for this @Roman , @eviltrout . I spent 2 complete days figuring this out.

@Roman , Do you think this feature needs to be backported? I think it should be so that people on tests-passed and release branches can also benifit. I think some if not most plugins that use `post_custom_fields’ need to handle this edge case.

@fzngagan looks like this is already on tests-passed, see Commits · discourse/discourse · GitHub

@merefield . Ohh, I didn’t notice.

在 :approved_post 事件中无法获取自定义字段

开发

Roman (Roman Rizzi) 2019 年8 月 14 日 17:42 5

我确认这是一个 bug。is_poll 未被存储在 payload 中，导致回调无效。

以下是修复此问题的 PR：

我还添加了一个新接口，以便我们可以从插件扩展允许的属性列表。

话题		回复	浏览量
Are custom_fields on posts/topics available via the API? Development	7	3483	2018 年10 月 24 日
What is the 'discourse post event allowed custom fields' setting for? Support events	3	492	2022 年11 月 2 日
Custom fields are not inserted with new ProseMirror editor Bug events	7	310	2025 年10 月 29 日
How to add custom fields to models Extras pavilion	48	9384	2025 年9 月 30 日
Unable to save custom fields after skipping post validation Development	1	852	2016 年12 月 31 日

在 :approved_post 事件中无法获取自定义字段

相关话题