# 未收到公告通知

**URL:** https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275
**Category:** Bug
**Created:** [2018年五月11日 15:52 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275 "2018-05-11T15:52:00Z")
**Posts on this page:** 14
**Page:** 1

<div class="post-metadata">

### Author: ![LeoMcA](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/leomca/32/87233_2.png) [@LeoMcA](https://meta.discourse.org/u/LeoMcA)
#### Post date: [2018年五月11日 15:52 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/1 "2018-05-11T15:52:00Z")

</div>

I have #feature:announcements set to _Watching_, but for the past 3 or so sets of release notes (like [this one](https://meta.discourse.org/t/discourse-2-0-0-beta9-release-notes/86799)) I haven’t received a notification for it, and have only found it in my _New_ list.

Once I open the topic, it says that it is set to _Watching_, despite my not receiving a notification for it.

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年五月11日 16:15 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2 "2018-05-11T16:15:15Z")

</div>

I would guess that the post is being drafted either as a PM or a ‘shared draft’, and therefore notifications are not being sent. See here:

> [@Does reassigning a category send a new email out to the group watching the new category?](https://meta.discourse.org/t/does-reassigning-a-category-send-a-new-email-out-to-the-group-watching-the-new-category/39249/8):
>
> On my dev instance I just tried these steps: User1 sets “Announcements” category to “Watching” User2 performs these actions: Private message (publish timer) Create a private message with self, set timer to publish to “Announcements” Staff only topic (publish timer) Create a topic in a staff only category, set timer to publish to “Announcements” Private message (manual publish) Create a private message with self, click Make Public Topic [(screenshot here)](https://meta.discourse.org/t/chatroom-integration-plugin-discourse-chat-integration/66522/29) This creates a public “Uncategor…

and more recently here:

> [@Notifications when a topic is recategorized](https://meta.discourse.org/t/notifications-when-a-topic-is-recategorized/63079/14):
>
> I think this is the same issue discussed here: I wonder if this also applies to publishing topics created using the shared drafts feature…

It looks like @tgxworld applied a related fix here

> [@Notifications when a topic is recategorized](https://meta.discourse.org/t/notifications-when-a-topic-is-recategorized/63079/15):
>
> @simon I fixed it in [https://github.com/discourse/discourse/commit/ee1eb1a5bd834ed49e7efe2ee58bb567556a8c7c](https://github.com/discourse/discourse/commit/ee1eb1a5bd834ed49e7efe2ee58bb567556a8c7c)

I just tried a few things locally:

- Watching #announcements
  - “Make PM Public”, then recategorise to #announcements
  - No notification received ❌

- Watching #annoucements
  - “Publish shared draft”
  - Notification received ✅

- Watching first post #announcements
  - “Publish shared draft”
  - Notification not received ❌

---

<div class="post-metadata">

### Author: ![jomaxro](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jomaxro/32/126216_2.png) [@jomaxro](https://meta.discourse.org/u/jomaxro)
#### Post date: [2018年五月11日 16:32 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/3 "2018-05-11T16:32:29Z")

</div>

> [@LeoMcA](#):
>
> but for the past 3 or so sets of release notes (like [this one](https://meta.discourse.org/t/discourse-2-0-0-beta9-release-notes/86799)) I haven’t received a notification for it,

@david very likely has the right idea. The last 3 or so release notes were created using the shared drafts feature. Previous notes were drafted elsewhere and posted “normally”. It looks like @tgxworld’s recent change likely fixed watching #feature:announcements, but we should probably fix the other 2 issues.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [2018年五月13日 23:27 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/4 "2018-05-13T23:27:51Z")

</div>

@tgxworld I would like you to fix this, this week if you have some time

A minimal fix here is that if a topic with 1 post is recategorized to a “watching” category notifications should go out.

It is a bit tricky here cause, what happens when you move something to #feature:announcements and then move it out of #feature:announcements ? We need to remove the watching status from all the people to be “correct”

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [2018年五月13日 23:56 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/6 "2018-05-13T23:56:42Z")

</div>

There is also the two full seconds of 307 SQL commands that somehow issue when you rename and recategorize a topic.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [2018年五月17日 08:17 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/7 "2018-05-17T08:17:32Z")

</div>

> [@david](#):
>
> Watching #announcements
> 
> - “Make PM Public”, then recategorise to #announcements
> - No notification received ❌

@david Was this not working for you even with [FIX: Retrigger notification when a topic is recategorized. · discourse/discourse@ee1eb1a · GitHub](https://github.com/discourse/discourse/commit/ee1eb1a5bd834ed49e7efe2ee58bb567556a8c7c) applied?

> [@david](#):
>
> - Watching first post #announcements
> - “Publish shared draft”
> - Notification not received ❌

This case is fixed in

[https://github.com/discourse/discourse/commit/147ea37115d043caf6b547933b97eabf34e9f27e](https://github.com/discourse/discourse/commit/147ea37115d043caf6b547933b97eabf34e9f27e)

> [@sam](#):
>
> It is a bit tricky here cause, what happens when you move something to #feature:announcements and then move it out of #feature:announcements ? We need to remove the watching status from all the people to be “correct”

I tested this locally and it looks we we already do this.

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年五月17日 08:31 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/8 "2018-05-17T08:31:18Z")

</div>

> [@tgxworld](#):
>
> @David\_Taylor Was this not working for you even with [FIX: Retrigger notification when a topic is recategorized. · discourse/discourse@ee1eb1a · GitHub](https://github.com/discourse/discourse/commit/ee1eb1a5bd834ed49e7efe2ee58bb567556a8c7c) applied?

I just tried again and this works fine, so I must have messed something up when testing. Sorry for the confusion!

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [2018年五月17日 08:33 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/9 "2018-05-17T08:33:03Z")

</div>

No worries! Thank you for working out the 3 scenarios!

---

<div class="post-metadata">

### Author: ![LeoMcA](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/leomca/32/87233_2.png) [@LeoMcA](https://meta.discourse.org/u/LeoMcA)
#### Post date: [2018年六月27日 11:03 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/12 "2018-06-27T11:03:09Z")

</div>

Unfortunately it doesn’t look like this is completely fixed, as it happened again for me with: [Discourse 2.1.0 beta 2 Release Notes](https://meta.discourse.org/t/discourse-2-1-0-beta-2-release-notes/90712) (I got no notification, only appeared in New, appeared as Watching once I opened it)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [2018年七月9日 07:44 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/13 "2018-07-09T07:44:41Z")

</div>

I’m 80% sure this has to do with posting as a ‘shared draft’, perhaps?

> [@Shared Drafts: Allow staff to collaborate on posts before publishing](https://meta.discourse.org/t/shared-drafts-allow-staff-to-collaborate-on-posts-before-publishing/83493):
>
> I’ve recently [merged a new feature](https://github.com/discourse/discourse/commit/b9abd7dc9e449d1c92cf593c925c53187bb742de) into Discourse called Shared Drafts. The feature is meant for forums where staff members want to work on drafts together before publishing them. How to Enable Go into your site’s settings and designate a category as shared drafts category: You can use the staff category that comes with Discourse to do this, or you can use a new category if you prefer. Make sure that the category is restricted to those who want to view a…

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [2018年七月17日 04:53 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/15 "2018-07-17T04:53:02Z")

</div>

@david can you have a look at the shared draft case?

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年七月18日 21:14 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/16 "2018-07-18T21:14:48Z")

</div>

It looks like most of the cases described above regressed 2 months ago, but this wasn’t picked up in the tests (because Sidekiq jobs don’t run normally in a test environment). Here’s a PR to fix:

[https://github.com/discourse/discourse/pull/6108](https://github.com/discourse/discourse/pull/6108)

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年七月24日 10:07 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/17 "2018-07-24T10:07:07Z")

</div>

This is now merged, so future #feature:announcements should trigger notifications correctly 🙂

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年八月7日 17:00 UTC](https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/18 "2018-08-07T17:00:09Z")

</div>

This topic was automatically closed after 14 days. New replies are no longer allowed.
