Notifications - "unread only" filter

Okay i will focus on that first, and will send you mockups of that page soon :slightly_smiling_face:

5 curtidas


Thoughts? @Johani, @jomaxro

4 curtidas

Ooo I like it! Nicely done.

4 curtidas

so is it final? May i start working on it?

Sure, but make sure you use select kit there and not a custom control

3 curtidas

sure, ill use select kit :slightly_smiling_face:

1 curtida

Ive used select kit and made a PR.
https://github.com/discourse/discourse/pull/9535

11 curtidas

Ive completed this task and my pull request is merged.

7 curtidas

@Ahmed_Gagan

One thing I noticed - it currently doesn’t pull all unread notifications. It only filters the first loaded ‘page’ of them, but if you have more unread ones in the past, you have to scroll down in the All view and only then switch to unread ones.

It would be fun if switching to Unread filter would load all unread notifications and not just the unread ones from the first page, if that makes sense :slight_smile:

EDIT.
I’ve just found out another bug, I think.
When you middle click in this view:

It should open a topic in a new tab, but instead it clears the notification without opening any new tabs.

4 curtidas

I’ll test it once again and will get back to you :slightly_smiling_face:

3 curtidas

Very excited to see this rolled out!

Thanks to everyone incubating this since January 2016 :heart_eyes:

4 curtidas

Started working on these changes will be submitted soon.

8 curtidas

I just merged @Ahmed_Gagan’s PR for this, and it’s working nicely for me on Meta :heart_eyes:

I’ll get that change deployed to your site in the next couple of hours @loginerror

9 curtidas