Odd browser in-page search behavior


(Patrick Klug) #1

I was just trying to search inside a topic using Chrome’s own search feature (Ctrl+F) and got some very odd results.

Example:

  1. Go here. (using Chrome on Windows)
  2. Press Ctrl+F and search for ‘quality’.

When I do this the result ranges from finding the first q, then stopping to closing the browser tab completely. Is this just a bug in Chrome or does Discourse incorrectly react to some keyboard shortcuts?


(Patrick Klug) #2

Now that I test it again, it works :confused:


(Sam Saffron) #3

Search within topic is not going to fly well with CTRLf

I intend to hijack it to use our built in search. It searches within topics anyway (and displays excerpt + multiple hits)


(Jeff Atwood) #4

We changed it so that ctrl+f triggers Discourse search only when there are more than 20 posts loaded in the current topic stream.

So on smaller topics, this now works like the browser default.

Only on larger topics will you get Discourse search, which is necessary because not all posts are loaded in the DOM (think 100+ replies) at any given time, only the visible ones are.


(system) #5

(Sam Saffron) #6