Onebox fail triggers "Unknown error saving post, try again."


(Adam Capriola) #1

I’m getting this error currently on my Discourse install (and here too) whenever I try to make a post that includes a link that fails to onebox, for whatever reason. I can’t really discern why some links are successfully “oneboxing” and some aren’t.

So for example, this link works:

http://www.sixprizes.com/2014/05/20/failing-to-plan-is-planning-to-fail-alternate-strategies-to-victory/

(I love that it’s picking up on WordPress SEO head tags, by the way!)

And then this link, doesn’t (and I can’t include it on a separate line, unformated, otherwise I get the error):

http://www.sixprizes.com/2014/04/23/as-the-format-turns-final-lists-of-nxd-xy-flashfire-set-review-and-updated-decks/

My only hunch is that the second link failed because that specific page is so lengthy. So, there are two bugs here:

  1. The onebox failing
  2. The post not going through because of the failed onebox

(Jeff Atwood) #2

Reclassifying this as support. Can you repro this on try.discourse.org?

If you can, please recategorize as bug.


(Adam Capriola) #3

Repro’d it both on here and try.discourse.org with that second link:

http://www.sixprizes.com/2014/04/23/as-the-format-turns-final-lists-of-nxd-xy-flashfire-set-review-and-updated-decks/


(Jeff Atwood) #4

This onebox issue is worth a look @eviltrout.


(Robin Ward) #5

I’ve got a fix for this in master:

https://github.com/discourse/discourse/commit/e0b72997db2515c125cc27da4954d6e14b171509


(Jeff Atwood) #6

(Sam Saffron) #7

hmmm, I made a bunch of changes to onboxer.rb in our code base to make it more resilient to onebox failures, we should ensure I worry that there is an edge case left, we need to also fix oneboxer.rb so it can not be crashed in this way.